doc: note message event listeners ref IPC channels - #11494
Closed
DiegoRBaquero wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jasnell
approved these changes
Feb 22, 2017
sam-github
approved these changes
Feb 22, 2017
Copy link
Copy Markdown
Contributor
|
@DiegoRBaquero can you add a more descriptive (but < 50 char) git commit message? "fixed thing" isn't helpful, it doesn't say what was broken or fixed about thing. How about
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@sam-github Yes! But... I committed through github, how do I go about changing the message? The commit description contains a more descriptive and detailed information |
Sorry, something went wrong.
The IPC channel is referenced with the message event too.
lpinca
approved these changes
Feb 22, 2017
Copy link
Copy Markdown
Contributor
|
You probably can't. With git its easy. Clone your repo, checkout your branch, do git commit --amend, edit the message and save it, then do git push -f. If you intend to contribute more to node, you'll have to learn to use git directly. I fixed it for you and pushed it to your branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
My CLI knowledge is limited to the basics. Thank you for sharing how to do it! |
Sorry, something went wrong.
cjihrig
approved these changes
Feb 24, 2017
sam-github
pushed a commit
to sam-github/node
that referenced
this pull request
Feb 24, 2017
The IPC channel is referenced with the message event too. PR-URL: nodejs#11494 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 25, 2017
The IPC channel is referenced with the message event too. PR-URL: nodejs#11494 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
The IPC channel is referenced with the message event too. PR-URL: #11494 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
The IPC channel is referenced with the message event too. PR-URL: #11494 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
The IPC channel is referenced with the message event too. PR-URL: #11494 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
The IPC channel is referenced with the message event too. PR-URL: #11494 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc