doc: package main can be directory with an index - #11581
Closed
bmeck wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jasnell
approved these changes
Feb 27, 2017
Copy link
Copy Markdown
Member
Author
|
Jenkins arm failure is false, if you look at Jenkins page it is a success |
Sorry, something went wrong.
This behavior dates back to 2011 but was not documented. PR-URL: nodejs#11581 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Member
|
@bmeck could you paste a link to the CI if you run it? CI: https://ci.nodejs.org/job/node-test-commit/8378/ The windows build also failed, but this is a doc change so I'm pretty confident it's unrelated. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@gibfahn sure, might want to update https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md as well to include that |
Sorry, something went wrong.
bmeck
added a commit
that referenced
this pull request
Mar 13, 2017
This behavior dates back to 2011 but was not documented. PR-URL: #11581 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Mar 14, 2017
This behavior dates back to 2011 but was not documented. PR-URL: nodejs#11581 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
jungx098
pushed a commit
to jungx098/node
that referenced
this pull request
Mar 21, 2017
This behavior dates back to 2011 but was not documented. PR-URL: nodejs#11581 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 17, 2017
This behavior dates back to 2011 but was not documented. PR-URL: #11581 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
This behavior dates back to 2011 but was not documented. PR-URL: #11581 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
This behavior dates back to 2011 but was not documented. PR-URL: nodejs/node#11581 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This behavior dates back to 2011 but was not documented.
@isaacs made the original change.
I am unsure if package.json in a directory should also be supported here and if ESM behavior should also have this.
Checklist
Affected core subsystem(s)
doc