FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: removed unused msg parameter in debug_agent by mr-spd · Pull Request #11833 · nodejs/node · GitHub

/ node Public

lib: removed unused msg parameter in debug_agent - #11833

Closed
mr-spd wants to merge 1 commit into
nodejs:masterfrom
delftswa2017:unused_parameter
ConversationCommits (1)ChecksFiles changed
Closed

lib: removed unused msg parameter in debug_agent#11833
mr-spd wants to merge 1 commit into
nodejs:masterfrom
delftswa2017:unused_parameter

Conversation

mr-spd commented Mar 13, 2017

Copy link
Copy Markdown
Contributor

Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

lib

gibfahn commented Mar 13, 2017

Copy link
Copy Markdown
Member

Minor nit: could you change removed->remove in the commit message?

See the Contributing Guidelines for more info.

Someone can do this on landing if you don't have time.

lib: remove unused msg parameter in debug_agent
068c8b4 
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.
mr-spd force-pushed the unused_parameter branch from 37384a5 to 068c8b4 Compare March 13, 2017 19:19
gibfahn approved these changes Mar 13, 2017
View reviewed changes

gibfahn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks

JacksonTian commented Mar 14, 2017

Copy link
Copy Markdown
Contributor

LGTM

hiroppy commented Mar 14, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/6831/

fhinkel commented Mar 15, 2017 •
edited by gibfahn
Loading

Copy link
Copy Markdown
Contributor

Thanks. Landed in 5bd1642

fhinkel closed this Mar 15, 2017
fhinkel pushed a commit that referenced this pull request Mar 15, 2017
lib: remove unused msg parameter in debug_agent
5bd1642 
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

PR-URL: #11833
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 20, 2017
lib: remove unused msg parameter in debug_agent
9cc712c 
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

PR-URL: nodejs#11833
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
italoacasas mentioned this pull request Mar 20, 2017
Merged
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
lib: remove unused msg parameter in debug_agent
f1ebeed 
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

PR-URL: nodejs#11833
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
lib: remove unused msg parameter in debug_agent
8068d3f 
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

PR-URL: #11833
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
lib: remove unused msg parameter in debug_agent
f8426d9 
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

PR-URL: #11833
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
MylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
lib: remove unused msg parameter in debug_agent
453f1b3 
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

PR-URL: nodejs/node#11833
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
This was referenced Mar 7, 2020
Open
Open
Open
Open
Open
Open
adamlaska mentioned this pull request Nov 30, 2023
Open
aliscco mentioned this pull request Dec 1, 2023
Open
leonardoadame mentioned this pull request Dec 1, 2023
Open
This was referenced Dec 1, 2023
Open
Open
This was referenced Dec 1, 2023
Open
Open
This was referenced Dec 1, 2023
Open
Open
adamlaska mentioned this pull request Dec 2, 2023
Open
aliscco mentioned this pull request Dec 2, 2023
Open
leonardoadame mentioned this pull request Dec 2, 2023
Open
This was referenced Dec 2, 2023
Open
Open
Open
Open
leonardoadame mentioned this pull request Dec 2, 2023
Open
This was referenced Dec 2, 2023
Open
Open
Open
This was referenced Dec 2, 2023
Open
Open
This was referenced Dec 2, 2023
Open
Open
This was referenced Dec 3, 2023
Open
Open
Open
aliscco mentioned this pull request Dec 3, 2023
Open
leonardoadame mentioned this pull request Dec 3, 2023
Open
aliscco mentioned this pull request Dec 3, 2023
Open
leonardoadame mentioned this pull request Dec 5, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
+4 more reviewers
fhinkel fhinkel approved these changes
danbev danbev approved these changes
hiroppy hiroppy approved these changes
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL