inspector: proper WS URLs when bound to 0.0.0.0 - #11850
Merged
eugeneo merged 1 commit intoMar 16, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@italoacasas - I am not sure how to create backporting pull requests, please advise. |
Sorry, something went wrong.
bnoordhuis
approved these changes
Mar 14, 2017
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Copy link
Copy Markdown
|
@eugeneo you did it great. Thank you |
Sorry, something went wrong.
italoacasas
approved these changes
Mar 14, 2017
jasnell
approved these changes
Mar 14, 2017
cjihrig
added a commit
that referenced
this pull request
Mar 21, 2017
cjihrig
added a commit
that referenced
this pull request
Mar 21, 2017
Copy link
Copy Markdown
Contributor
|
similar to other inspector stuff. Any chance of a mass backport? |
Sorry, something went wrong.
imyller
added a commit
to imyller/meta-nodejs
that referenced
this pull request
Apr 20, 2017
Notable changes:
* deps: Add node-inspect 1.10.6 (Jan Krems) nodejs/node#11869
* inspector: proper WS URLs when bound to 0.0.0.0 (Eugene Ostroukhov) nodejs/node#11850
* tls: fix segfault on destroy after partial read. (Ben Noordhuis) nodejs/node#11898
PR-URL: nodejs/node#11941
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON target list response will now return appropriate IP address
for instances listening on 0.0.0.0.
Refs: #11591
PR-URL: #11755
Reviewed-By: James Snell jasnell@gmail.com
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Checklist
Affected core subsystem(s)
inspector: IP is not obtained from the socket
This is a backport of #11755. The only change is that the test now checks if common.skipIfInspectorDisabled exists before calling it.