FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: cherry-pick ca0f9573 from V8 upstream by ofrobots · Pull Request #11940 · nodejs/node · GitHub

/ node Public

deps: cherry-pick ca0f9573 from V8 upstream - #11940

Closed
ofrobots wants to merge 1 commit into
nodejs:v7.x-stagingfrom
ofrobots:arraybuffer-new-oom
ConversationCommits (1)ChecksFiles changed
Closed

deps: cherry-pick ca0f9573 from V8 upstream#11940
ofrobots wants to merge 1 commit into
nodejs:v7.x-stagingfrom
ofrobots:arraybuffer-new-oom

Conversation

ofrobots commented Mar 20, 2017

Copy link
Copy Markdown
Contributor

Original commit message:

Trigger OOM crash if no memory returned in v8::ArrayBuffer::New and v…
…8::SharedArrayBuffer::New.

This API does not allow reporting failure, but we should crash rather than have
the caller get an ArrayBuffer that isn't properly set up.

BUG=chromium:681843

Review-Url: https://codereview.chromium.org/2641953002
Cr-Commit-Position: refs/heads/master@{#42511}

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps:v8

deps: cherry-pick ca0f9573 from V8 upstream
4db4d0d 
Original commit message:
  Trigger OOM crash if no memory returned in v8::ArrayBuffer::New and v…
  …8::SharedArrayBuffer::New.

  This API does not allow reporting failure, but we should crash rather than have
  the caller get an ArrayBuffer that isn't properly set up.

  BUG=chromium:681843

  Review-Url: https://codereview.chromium.org/2641953002
  Cr-Commit-Position: refs/heads/master@{nodejs#42511}
ofrobots added lts-watch-v4.x v8 engine Issues and PRs related to the V8 dependency. labels Mar 20, 2017
nodejs-github-bot added v7.x v8 engine Issues and PRs related to the V8 dependency. labels Mar 20, 2017

ofrobots commented Mar 20, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/6938/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/615/

/cc @nodejs/v8

bnoordhuis approved these changes Mar 20, 2017
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM but let me just note that ValueDeserializer::ReadJSArrayBuffer() and WebAssemblyMemory() also don't check the return value.

We don't use either in core at the moment but there is an open pull request that introduces ValueDeserializer bindings.

italoacasas commented Mar 21, 2017

Copy link
Copy Markdown

Landed in staging

ofrobots deleted the arraybuffer-new-oom branch March 23, 2017 01:00

MylesBorins commented Apr 18, 2017

Copy link
Copy Markdown
Contributor

FWIW this landed without appropriate meta data

MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
deps: cherry-pick ca0f9573 from V8 upstream
d7d0dba 
Original commit message:
  Trigger OOM crash if no memory returned in v8::ArrayBuffer::New and v…
  …8::SharedArrayBuffer::New.

  This API does not allow reporting failure, but we should crash rather than have
  the caller get an ArrayBuffer that isn't properly set up.

  BUG=chromium:681843

  Review-Url: https://codereview.chromium.org/2641953002
  Cr-Commit-Position: refs/heads/master@{#42511}

PR-URL: #11940
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins commented Apr 18, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Landed on v6.x in d7d0dba
Landed in v4.x in 929fd6c

4.x required some manual care... please review

c v4.xi: https://ci.nodejs.org/job/node-test-commit-v8-linux/656/
ci v6.x: https://ci.nodejs.org/job/node-test-commit-v8-linux/655/

edit 2: CI GREEN!

MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
deps: cherry-pick ca0f9573 from V8 upstream
929fd6c 
Original commit message:
  Trigger OOM crash if no memory returned in v8::ArrayBuffer::New and v…
  …8::SharedArrayBuffer::New.

  This API does not allow reporting failure, but we should crash rather than have
  the caller get an ArrayBuffer that isn't properly set up.

  BUG=chromium:681843

  Review-Url: https://codereview.chromium.org/2641953002
  Cr-Commit-Position: refs/heads/master@{#42511}

PR-URL: #11940
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
bnoordhuis referenced this pull request Apr 18, 2017
deps: cherry-pick ca0f9573 from V8 upstream
ca31986 
Original commit message:
  Trigger OOM crash if no memory returned in v8::ArrayBuffer::New and v…
  …8::SharedArrayBuffer::New.

  This API does not allow reporting failure, but we should crash rather than have
  the caller get an ArrayBuffer that isn't properly set up.

  BUG=chromium:681843

  Review-Url: https://codereview.chromium.org/2641953002
  Cr-Commit-Position: refs/heads/master@{#42511}
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
deps: cherry-pick ca0f9573 from V8 upstream
ab3fdf5 
Original commit message:
  Trigger OOM crash if no memory returned in v8::ArrayBuffer::New and v…
  …8::SharedArrayBuffer::New.

  This API does not allow reporting failure, but we should crash rather than have
  the caller get an ArrayBuffer that isn't properly set up.

  BUG=chromium:681843

  Review-Url: https://codereview.chromium.org/2641953002
  Cr-Commit-Position: refs/heads/master@{#42511}

PR-URL: #11940
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
deps: cherry-pick ca0f9573 from V8 upstream
8cdddcd 
Original commit message:
  Trigger OOM crash if no memory returned in v8::ArrayBuffer::New and v…
  …8::SharedArrayBuffer::New.

  This API does not allow reporting failure, but we should crash rather than have
  the caller get an ArrayBuffer that isn't properly set up.

  BUG=chromium:681843

  Review-Url: https://codereview.chromium.org/2641953002
  Cr-Commit-Position: refs/heads/master@{#42511}

PR-URL: #11940
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This was referenced Apr 19, 2017
Merged
Merged
gibfahn pushed a commit to ibmruntimes/node that referenced this pull request May 3, 2017
deps: cherry-pick ca0f9573 from V8 upstream
f3e8bea 
Original commit message:
  Trigger OOM crash if no memory returned in v8::ArrayBuffer::New and v…
  …8::SharedArrayBuffer::New.

  This API does not allow reporting failure, but we should crash rather than have
  the caller get an ArrayBuffer that isn't properly set up.

  BUG=chromium:681843

  Review-Url: https://codereview.chromium.org/2641953002
  Cr-Commit-Position: refs/heads/master@{#42511}

PR-URL: nodejs/node#11940
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
deps: cherry-pick ca0f9573 from V8 upstream
677035e 
Original commit message:
  Trigger OOM crash if no memory returned in v8::ArrayBuffer::New and v…
  …8::SharedArrayBuffer::New.

  This API does not allow reporting failure, but we should crash rather than have
  the caller get an ArrayBuffer that isn't properly set up.

  BUG=chromium:681843

  Review-Url: https://codereview.chromium.org/2641953002
  Cr-Commit-Position: refs/heads/master@{#42511}

PR-URL: nodejs/node#11940
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
jasnell jasnell approved these changes
addaleax addaleax approved these changes

Assignees

No one assigned

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL