v8: fix compilation on PPC64 when libc musl is used instead of glibc - #12081
Closed
gromero wants to merge 1 commit into
Closed
v8: fix compilation on PPC64 when libc musl is used instead of glibc#12081gromero wants to merge 1 commit into
gromero wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Musl on Power does not define regs member as a pt_regs pointer type, hence it's necessary to use member gp_regs instead.
gromero
force-pushed
the
ppc-mcontext-pr
branch
from
5c3cefe to
975a7a2
Compare
March 27, 2017 22:22
Copy link
Copy Markdown
Contributor
|
Is this upstreamed in V8? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Closing, no follow-up. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Really sorry for not being able to follow up this. @rgdoliveira kindly already submitted the patch to v8 and it's currently under review: https://chromium-review.googlesource.com/c/602327 @bnoordhuis do you mind to re-open that issue given the current facts? Thank you in advance. Regards. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
See also the guide: https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md#unfixed-upstream-bugs |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Musl on Power does not define regs member as a pt_regs pointer
type, hence it's necessary to use member gp_regs instead.
Affected core subsystem(s)
v8 profiler sampler. It fails to build breaking compilation on ppc64le + musl