FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "Revert "repl: disable Ctrl+C support..." by MylesBorins · Pull Request #12123 · nodejs/node · GitHub

/ node Public

Revert "Revert "repl: disable Ctrl+C support..." - #12123

Merged
MylesBorins merged 1 commit into
nodejs:v6.x-stagingfrom
MylesBorins:revert-windows-repl
Mar 29, 2017
ConversationCommits (1)ChecksFiles changed
Merged

Revert "Revert "repl: disable Ctrl+C support..."#12123
MylesBorins merged 1 commit into
nodejs:v6.x-stagingfrom
MylesBorins:revert-windows-repl

Conversation

MylesBorins commented Mar 29, 2017

Copy link
Copy Markdown
Contributor

Full original message:

Revert "repl: disable Ctrl+C support on win32 for now"

This reverts commit 1d400ea.

Refs: #8645

MylesBorins requested a review from addaleax March 29, 2017 20:07
nodejs-github-bot added repl Issues and PRs related to the REPL subsystem. v6.x labels Mar 29, 2017
addaleax approved these changes Mar 29, 2017
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, can’t wait for the revert ;)

addaleax commented Mar 29, 2017

Copy link
Copy Markdown
Member

Maybe also add Fixes: https://github.com/nodejs/node/issues/12085

Revert "Revert "repl: disable Ctrl+C support..."
ee453a4 
Full original message:

  Revert "repl: disable Ctrl+C support on win32 for now"

This reverts commit 1d400ea.

Fixes: nodejs#12085
Refs: nodejs#8645

PR-URL: nodejs#12123
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins force-pushed the revert-windows-repl branch from f924833 to ee453a4 Compare March 29, 2017 20:30
MylesBorins merged commit ee453a4 into nodejs:v6.x-staging Mar 29, 2017

MylesBorins commented Mar 29, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

landed in 59b869e

edit: updated sha

jasnell commented Mar 29, 2017

Copy link
Copy Markdown
Member

Hmm.. could you include a short explanation here about why it is reverted, just so folks have the context.

MylesBorins added a commit that referenced this pull request Mar 29, 2017
Revert "Revert "repl: disable Ctrl+C support..."
59b869e 
Full original message:

  Revert "repl: disable Ctrl+C support on win32 for now"

The original fix was a stop gap until a libuv update landed.
As the libuv update has not yet landed on v6.x the revert should
not have landed. This commit reverts 1d400ea reapplying the
stopgap fix until we update libuv.

Fixes: #12085
Refs: #8645

PR-URL: #12123
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins commented Mar 29, 2017

Copy link
Copy Markdown
Contributor Author

I've updated the commit with the following copy. the sha has been updated above

The original fix was a stop gap until a libuv update landed.
As the libuv update has not yet landed on v6.x the revert should
not have landed. This commit reverts 1d400ea reapplying the
stopgap fix until we update libuv.

MylesBorins added a commit that referenced this pull request Mar 29, 2017
Revert "Revert "repl: disable Ctrl+C support..."
64fc5a4 
Full original message:

  Revert "repl: disable Ctrl+C support on win32 for now"

The original fix was a stop gap until a libuv update landed.
As the libuv update has not yet landed on v6.x the revert should
not have landed. This commit reverts 1d400ea reapplying the
stopgap fix until we update libuv.

Fixes: #12085
Refs: #8645

PR-URL: #12123
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins mentioned this pull request Mar 29, 2017
Merged
MylesBorins added a commit that referenced this pull request Mar 29, 2017
2017-04-04, Version 6.10.2 'Boron' (LTS)
be03658 
This is a special LTS to fix a number of regressions that were found
on the 6.10.x release line.

This includes:

 * a fix for memory leak in the crypto module that
   was introduced in 6.10.1
 * a fix for a regression introduced to the windows repl in 6.10.0
 * a backported fix for V8 to stop a segfault that could occur
   when using spread syntax

It also includes an upgrade to zlib 1.2.11 to fix a numberof low
severity CVEs that were present in zlib 1.2.8.

http://seclists.org/oss-sec/2016/q4/602

Notable changes

* crypto:
  - fix memory leak if certificate is revoked (Tom Atkinson)
    #12089
* deps:
  - upgrade zlib to 1.2.11 (Sam Roberts)
    #10980
  - backport V8 fixes for spread syntax regression causing segfaults
    (Michaël Zasso) #12037
* repl:
  - Revert commit that broke REPL display on Windows (Myles Borins)
    #12123

gibfahn commented Mar 29, 2017

Copy link
Copy Markdown
Member

Does this mean we'll have a Revert "Revert "Revert "repl: disable Ctrl+C... in the next update?

addaleax commented Mar 29, 2017

Copy link
Copy Markdown
Member

@gibfahn The original Revert (#8645) was landed too early in v6.x, it needs to come with the libuv 1.10.x upgrade. So, yes, together with that we should be able to land a Revert³. 😄

MylesBorins added a commit that referenced this pull request Apr 4, 2017
2017-04-04, Version 6.10.2 'Boron' (LTS)
fbc9fde 
This is a special LTS to fix a number of regressions that were found
on the 6.10.x release line.

This includes:

 * a fix for memory leak in the crypto module that
   was introduced in 6.10.1
 * a fix for a regression introduced to the windows repl in 6.10.0
 * a backported fix for V8 to stop a segfault that could occur
   when using spread syntax

It also includes an upgrade to zlib 1.2.11 to fix a numberof low
severity CVEs that were present in zlib 1.2.8.

http://seclists.org/oss-sec/2016/q4/602

Notable changes

* crypto:
  - fix memory leak if certificate is revoked (Tom Atkinson)
    #12089
* deps:
  - upgrade zlib to 1.2.11 (Sam Roberts)
    #10980
  - backport V8 fixes for spread syntax regression causing segfaults
    (Michaël Zasso) #12037
* repl:
  - Revert commit that broke REPL display on Windows (Myles Borins)
    #12123
MylesBorins added a commit to MylesBorins/node that referenced this pull request Apr 4, 2017
2017-04-04, Version 6.10.2 'Boron' (LTS)
28f8b17 
This is a special LTS to fix a number of regressions that were found
on the 6.10.x release line.

This includes:

 * a fix for memory leak in the crypto module that
   was introduced in 6.10.1
 * a fix for a regression introduced to the windows repl in 6.10.0
 * a backported fix for V8 to stop a segfault that could occur
   when using spread syntax

It also includes an upgrade to zlib 1.2.11 to fix a numberof low
severity CVEs that were present in zlib 1.2.8.

http://seclists.org/oss-sec/2016/q4/602

Notable changes

* crypto:
  - fix memory leak if certificate is revoked (Tom Atkinson)
    nodejs#12089
* deps:
  - upgrade zlib to 1.2.11 (Sam Roberts)
    nodejs#10980
  - backport V8 fixes for spread syntax regression causing segfaults
    (Michaël Zasso) nodejs#12037
* repl:
  - Revert commit that broke REPL display on Windows (Myles Borins)
    nodejs#12123
imyller added a commit to imyller/meta-nodejs that referenced this pull request Apr 20, 2017
2017-04-04, Version 6.10.2 'Boron' (LTS)
7db63fb 
    This is a special LTS to fix a number of regressions that were found
    on the 6.10.x release line.

    This includes:

     * a fix for memory leak in the crypto module that
       was introduced in 6.10.1
     * a fix for a regression introduced to the windows repl in 6.10.0
     * a backported fix for V8 to stop a segfault that could occur
       when using spread syntax

    It also includes an upgrade to zlib 1.2.11 to fix a numberof low
    severity CVEs that were present in zlib 1.2.8.

    http://seclists.org/oss-sec/2016/q4/602

    Notable changes

    * crypto:
      - fix memory leak if certificate is revoked (Tom Atkinson)
        nodejs/node#12089
    * deps:
      - upgrade zlib to 1.2.11 (Sam Roberts)
        nodejs/node#10980
      - backport V8 fixes for spread syntax regression causing segfaults
        (Michaël Zasso) nodejs/node#12037
    * repl:
      - Revert commit that broke REPL display on Windows (Myles Borins)
        nodejs/node#12123

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
imyller added a commit to imyller/meta-nodejs that referenced this pull request Apr 20, 2017
2017-04-04, Version 6.10.2 'Boron' (LTS)
d8517db 
    This is a special LTS to fix a number of regressions that were found
    on the 6.10.x release line.

    This includes:

     * a fix for memory leak in the crypto module that
       was introduced in 6.10.1
     * a fix for a regression introduced to the windows repl in 6.10.0
     * a backported fix for V8 to stop a segfault that could occur
       when using spread syntax

    It also includes an upgrade to zlib 1.2.11 to fix a numberof low
    severity CVEs that were present in zlib 1.2.8.

    http://seclists.org/oss-sec/2016/q4/602

    Notable changes

    * crypto:
      - fix memory leak if certificate is revoked (Tom Atkinson)
        nodejs/node#12089
    * deps:
      - upgrade zlib to 1.2.11 (Sam Roberts)
        nodejs/node#10980
      - backport V8 fixes for spread syntax regression causing segfaults
        (Michaël Zasso) nodejs/node#12037
    * repl:
      - Revert commit that broke REPL display on Windows (Myles Borins)
        nodejs/node#12123

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
bzoz mentioned this pull request May 19, 2017
Closed
MylesBorins mentioned this pull request Nov 1, 2017
Closed
MylesBorins deleted the revert-windows-repl branch November 14, 2017 17:45
baby636 mentioned this pull request Jun 22, 2022
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes

Assignees

No one assigned

Labels

repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL