doc: add logo to README - #12148
Conversation
Sorry, something went wrong.
gibfahn
left a comment
There was a problem hiding this comment.
Looks very nice
Sorry, something went wrong.
|
You made that SVG, right? Have you considered uploading it as a newer/better version of https://en.wikipedia.org/wiki/File:Node.js_logo.svg? |
Sorry, something went wrong.
|
@addaleax the logos are all in https://github.com/nodejs/nodejs.org/blob/master/static/images/. The Illustrator files from which SVGs can be generated, are from Amanda Cohen by way of @gtewallace (ref nodejs/evangelism#179). |
Sorry, something went wrong.
| [](https://gitter.im/nodejs/node?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) [](https://bestpractices.coreinfrastructure.org/projects/29) | ||
| <p align="center"> | ||
| <a href="https://nodejs.org/"> | ||
| <img src="https://nodejs.org/static/images/logo-light.svg" width="400" /> |
There was a problem hiding this comment.
An alt attribute seems appropriate here for screen readers (ditto below).
Sorry, something went wrong.
There was a problem hiding this comment.
Yes, should have an alt attribute and it should probably be empty: alt=""
Sorry, something went wrong.
There was a problem hiding this comment.
Why not alt="Node.js logo"?
Sorry, something went wrong.
There was a problem hiding this comment.
We should follow guidance of things like http://webaim.org/techniques/alttext/#logos. "Node.js home page" is probably what we want per that doc. Specifically, the alt text should likely not contain the word "logo".
Sorry, something went wrong.
There was a problem hiding this comment.
I think I'll just go with alt="Node.js" and remove the link on the logo as there are already multiple links in the document that link to the homepage.
Sorry, something went wrong.
|
Good idea |
Sorry, something went wrong.
|
@addaleax updated the image on Wikimedia. |
Sorry, something went wrong.
Adds a centered logo to the README to make it a little more festive. As centering is not possible in pure Markdown, a bit of HTML is used. PR-URL: #12148 Ref: #6920 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
|
I noticed that GitHub's Markdown renderer did wrap the logo in a <a> tag linking to the image source. Probably better to add our own <a> to override that. |
Sorry, something went wrong.
Adds a centered logo to the README to make it a little more festive. As centering is not possible in pure Markdown, a bit of HTML is used. PR-URL: nodejs#12148 Ref: nodejs#6920 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Adds a centered logo to the README to make it a little more festive. As centering is not possible in pure Markdown, a bit of HTML is used. PR-URL: #12148 Ref: #6920 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Adds a centered logo to the README to make it a little more festive. As centering is not possible in pure Markdown, a bit of HTML is used. PR-URL: #12148 Ref: #6920 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Adds a centered logo to the README to make it a little more festive. As centering is not possible in pure Markdown, a bit of HTML is used. PR-URL: nodejs/node#12148 Ref: nodejs/node#6920 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Checklist
Description
Added a centered SVG logo to the README to make it a little more festive. As centering is not possible in pure Markdown, I had to use a bit of HTML.
Ref: #6920
Preview