FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: support dtrace on ARM by bradleythughes · Pull Request #12193 · nodejs/node · GitHub

/ node Public

build: support dtrace on ARM - #12193

Closed
bradleythughes wants to merge 1 commit into
nodejs:masterfrom
bradleythughes:configure-support-dtrace-on-arm
Closed

build: support dtrace on ARM#12193
bradleythughes wants to merge 1 commit into
nodejs:masterfrom
bradleythughes:configure-support-dtrace-on-arm

Conversation

Copy link
Copy Markdown
Member

Use the same dtrace command on ARM as on i386. Patch obtained from
FreeBSD PR 218081 [1].

  1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218081
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Use the same dtrace command on ARM as on i386. Patch obtained from
FreeBSD PR 218081 [1].

1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218081
nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Apr 3, 2017
vsemozhetbyt added the arm Issues and PRs related to the ARM architecture. label Apr 3, 2017

Copy link
Copy Markdown
Contributor

jasnell commented Apr 18, 2017

Copy link
Copy Markdown
Member

lpinca commented May 27, 2017

Copy link
Copy Markdown
Member

lpinca commented May 27, 2017

Copy link
Copy Markdown
Member

Landed in f84666f.

lpinca closed this May 27, 2017
lpinca pushed a commit that referenced this pull request May 27, 2017
Use the same dtrace command on ARM as on i386. Patch obtained from
FreeBSD PR 218081 [1].

1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218081

PR-URL: #12193
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request May 28, 2017
Use the same dtrace command on ARM as on i386. Patch obtained from
FreeBSD PR 218081 [1].

1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218081

PR-URL: #12193
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell mentioned this pull request May 28, 2017
bradleythughes deleted the configure-support-dtrace-on-arm branch May 31, 2017 11:01
bradleythughes restored the configure-support-dtrace-on-arm branch May 31, 2017 11:01
bradleythughes deleted the configure-support-dtrace-on-arm branch June 1, 2017 18:02
gibfahn mentioned this pull request Jun 15, 2017
3 tasks

Copy link
Copy Markdown
Contributor

Should this be enabled for v6.x?

Copy link
Copy Markdown
Member Author

Hi, sorry for the late response (vacation). Ideally, yes, this should be in 6.x as well.

MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
Use the same dtrace command on ARM as on i386. Patch obtained from
FreeBSD PR 218081 [1].

1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218081

PR-URL: #12193
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
Use the same dtrace command on ARM as on i386. Patch obtained from
FreeBSD PR 218081 [1].

1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218081

PR-URL: #12193
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Aug 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arm Issues and PRs related to the ARM architecture. build Issues and PRs related to build files or the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL