FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: create test_addons function by danbev · Pull Request #12204 · nodejs/node · GitHub

/ node Public

build: create test_addons function - #12204

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:addons_test_function
ConversationCommits (1)ChecksFiles changed
Closed

build: create test_addons function#12204
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:addons_test_function

Conversation

danbev commented Apr 4, 2017

Copy link
Copy Markdown
Contributor

test/addons/.buildstamp and test/addons-napi/.buildstamp targets are
very similar except that they operate on different directories. This
commit extracts the common parts into a function to avoid the
duplication.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Apr 4, 2017

danbev commented Apr 4, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/7191/

addaleax reviewed Apr 4, 2017
View reviewed changes
Comment thread Makefile Outdated

addaleax Apr 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Btw, @Fishrock123 recently asked on IRC whether we could parallelize addon building… any chance there’s an easy way to do this in make?

danbev Apr 4, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Not off the top of my head (only know about the -j flag to make for that) but I'll take a look and see what options exist.

danbev Apr 5, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@addaleax I've added a commit now for this. Let me know what you think.

danbev Apr 5, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I created #12230 since making the building of addons parallel does not really relate to this PR. I'll remove also remove that commit from this PR.

danbev commented Apr 4, 2017

Copy link
Copy Markdown
Contributor Author

I windows failure looks unrelated to this commit:

not ok 32 parallel/test-cli-syntax
  ---
  duration_ms: 3.104
  severity: fail
  stack: |-
    
    assert.js:82
      throw new assert.AssertionError({
      ^
    AssertionError: 'c:\\workspace\\node-test-binary-windows\\RUN_SUBSET\\2\\VS_VERSION\\vcbt2015\\label\\win10\\Release\\node.exe: either --check o === 'c:\\workspace\\node-test-binary-windows\\RUN_SUBSET\\2\\VS_VERSION\\vcbt2015\\label\\win10\\Release\\node.exe: either --check o
        at c:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vcbt2015\label\win10\test\parallel\test-cli-syntax.js:127:12
        at Array.forEach (native)
        at c:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vcbt2015\label\win10\test\parallel\test-cli-syntax.js:123:20
        at Array.forEach (native)
        at Object.<anonymous> (c:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vcbt2015\label\win10\test\parallel\test-cli-syntax.js:122:19)
        at Module._compile (module.js:607:30)
        at Object.Module._extensions..js (module.js:618:10)
        at Module.load (module.js:516:32)
        at tryModuleLoad (module.js:466:12)
        at Function.Module._load (module.js:458:3)

Trott commented Apr 4, 2017

Copy link
Copy Markdown
Member

The Windows failure was a problem on the master branch and has since been fixed.

danbev commented Apr 4, 2017

Copy link
Copy Markdown
Contributor Author

The Windows failure was a problem on the master branch and has since been fixed.

Thanks for that, I'll rebase and rerun Ci.

danbev force-pushed the addons_test_function branch from 476b1cc to 1bd2f8e Compare April 4, 2017 17:30

danbev commented Apr 4, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/7202/

danbev commented Apr 4, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/7206/

mscdex added addons Issues and PRs related to native addons. test Issues and PRs related to the tests. labels Apr 4, 2017
build: create test_addons function
1fb7d60 
test/addons/.buildstamp and test/addons-napi/.buildstamp targets are
very similar except that they operate on different directories. This
commit extracts the common parts into a function to avoid the
duplication.
danbev force-pushed the addons_test_function branch from fff95d6 to 1fb7d60 Compare April 5, 2017 11:26

danbev commented Apr 5, 2017

Copy link
Copy Markdown
Contributor Author

Closing in favour of #12231

danbev closed this Apr 5, 2017
refack added the embedding Issues and PRs related to embedding Node.js in another project. label Aug 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax left review comments
bnoordhuis bnoordhuis approved these changes
jasnell jasnell approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

addons Issues and PRs related to native addons. build Issues and PRs related to build files or the CI. embedding Issues and PRs related to embedding Node.js in another project. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL