FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: document the performance team by gibfahn · Pull Request #12213 · nodejs/node · GitHub

/ node Public

doc: document the performance team - #12213

Merged
gibfahn merged 1 commit into
nodejs:masterfrom
gibfahn:perf-team
Apr 8, 2017
ConversationCommits (1)ChecksFiles changed
Merged

doc: document the performance team#12213
gibfahn merged 1 commit into
nodejs:masterfrom
gibfahn:perf-team

Conversation

gibfahn commented Apr 4, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Can be cc'ed with @nodejs/performance.

I added some people: @mscdex @vsemozhetbyt @joyeecheung @TimothyGu @lpinca

If anyone else wants to join and be cc/ed on issues, feel free to request access (or remove yourself if you don't want to be on the team).

Link to team

Refs: #12194 (comment)

Checklist
Affected core subsystem(s)

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 4, 2017
joyeecheung approved these changes Apr 4, 2017
View reviewed changes

joyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Wow this is quick. Thanks!

lpinca commented Apr 4, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

@gibfahn thanks but I don't consider myself a performance expert :) gonna remove myself from the team.

lpinca commented Apr 4, 2017

Copy link
Copy Markdown
Member

I think @mcollina and @trevnorris are good candidates for the team instead.

mcollina commented Apr 4, 2017

Copy link
Copy Markdown
Member

I've just request access.

mcollina approved these changes Apr 4, 2017
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

lpinca commented Apr 4, 2017

Copy link
Copy Markdown
Member

Also @petkaantonov if he is still active.

lpinca commented Apr 4, 2017

Copy link
Copy Markdown
Member

One last: @benjamingr, sorry about the spam.

P.S. I'm probably missing other good candidates :)

joyeecheung reviewed Apr 4, 2017
View reviewed changes
Comment thread doc/onboarding-extras.md Outdated

joyeecheung Apr 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just noticed.. should we replace the row for benchmark/* above too?

gibfahn Apr 4, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I considered it, but I'm not sure. That's probably a question for @nodejs/benchmarking.

mhdawson Apr 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It already has @nodejs/benhmarking and mscdex is not part of that team but is interested in the core benchmarks

vsemozhetbyt commented Apr 4, 2017

Copy link
Copy Markdown
Contributor

Maybe @fhinkel would be interested.

benjamingr commented Apr 4, 2017

Copy link
Copy Markdown
Member

Sure

gibfahn commented Apr 4, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

Added all the people mentioned, that way they can leave if they want.

EDIT: You're all team maintainers, so if you want to add someone go for it!

@gibfahn thanks but I don't consider myself a performance expert :) gonna remove myself from the team.

@lpinca The idea isn't that these are a list of performance experts (otherwise it'd probably be a short list 😁 ). It's just to have a list of people who are willing to look at performance issues and PRs. Feel free to remove yourself if you want, but being in the team doesn't mean you have to approve PRs or anything.

mhdawson approved these changes Apr 4, 2017
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Comment thread doc/onboarding-extras.md Outdated

mhdawson Apr 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It already has @nodejs/benhmarking and mscdex is not part of that team but is interested in the core benchmarks

mscdex added the performance Issues and PRs related to the performance of Node.js. label Apr 4, 2017
doc: document the performance team
96619fc 
Can be cc'ed with `@nodejs/performance`.

PR-URL: nodejs#12213
Refs: nodejs#12194 (comment)
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gibfahn merged commit 96619fc into nodejs:master Apr 8, 2017
gibfahn deleted the perf-team branch April 8, 2017 09:57
italoacasas pushed a commit to italoacasas/node that referenced this pull request Apr 10, 2017
doc: document the performance team
376f5ef 
Can be cc'ed with `@nodejs/performance`.

PR-URL: nodejs#12213
Refs: nodejs#12194 (comment)
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
italoacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
doc: document the performance team
c520aef 
Can be cc'ed with `@nodejs/performance`.

PR-URL: #12213
Refs: #12194 (comment)
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
doc: document the performance team
7e67176 
Can be cc'ed with `@nodejs/performance`.

PR-URL: #12213
Refs: #12194 (comment)
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
doc: document the performance team
ca0034d 
Can be cc'ed with `@nodejs/performance`.

PR-URL: nodejs/node#12213
Refs: nodejs/node#12194 (comment)
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joyeecheung joyeecheung approved these changes
mcollina mcollina approved these changes
jasnell jasnell approved these changes
lpinca lpinca approved these changes
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. performance Issues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL