FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: skip irrelevant test on Windows by Trott · Pull Request #12261 · nodejs/node · GitHub

/ node Public

test: skip irrelevant test on Windows - #12261

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-ci
ConversationCommits (1)ChecksFiles changed
Closed

test: skip irrelevant test on Windows#12261
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-ci

Conversation

Trott commented Apr 6, 2017

Copy link
Copy Markdown
Member

Skip test-cluster-disconnect-handles on Windows.

Refs: #12197 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: skip irrelevant test on Windows
4e05220 
Skip test-cluster-disconnect-handles on Windows.

Refs: nodejs#12197 (comment)
Trott added the test Issues and PRs related to the tests. label Apr 6, 2017
Trott mentioned this pull request Apr 6, 2017
Closed
4 tasks

Trott commented Apr 6, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/7249/

Trott commented Apr 6, 2017

Copy link
Copy Markdown
Member Author

If CI is green, I would strongly advocate for landing this immediately. Needs an LGTM or two, though....

hybrist commented Apr 6, 2017

Copy link
Copy Markdown
Contributor

First of all: Sorry, should've looked more closely at the semantics of known_issues. Trying to understand this change - does this mean the test passes on non-Windows? Confused because I would expect it to fail (given that this cluster.setup uses a now invalid flag).

Trott commented Apr 6, 2017

Copy link
Copy Markdown
Member Author

@jkrems This means that the test will be skipped. It won't run at all on Windows.

The current version of the test has code that checks to see if it's running on Windows and, if so, exits, which means that it doesn't fail as expected. Yeah, it's confusing.

hybrist commented Apr 6, 2017

Copy link
Copy Markdown
Contributor

Ah, missed that early return. Thanks for explaining! :)

Trott commented Apr 6, 2017

Copy link
Copy Markdown
Member Author

CI is green. Landing.

Trott commented Apr 6, 2017

Copy link
Copy Markdown
Member Author

Landed in a94a5da

Trott closed this Apr 6, 2017
Trott added a commit to Trott/io.js that referenced this pull request Apr 6, 2017
test: skip irrelevant test on Windows
a94a5da 
Skip test-cluster-disconnect-handles on Windows.

PR-URL: nodejs#12261
Ref: nodejs#12197 (comment)
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Apr 6, 2017
Merged
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Apr 10, 2017
test: skip irrelevant test on Windows
3cdd04b 
Skip test-cluster-disconnect-handles on Windows.

PR-URL: nodejs#12261
Ref: nodejs#12197 (comment)
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
test: skip irrelevant test on Windows
6c4f786 
Skip test-cluster-disconnect-handles on Windows.

PR-URL: #12261
Ref: #12197 (comment)
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
test: skip irrelevant test on Windows
a30ae72 
Skip test-cluster-disconnect-handles on Windows.

PR-URL: #12261
Ref: #12197 (comment)
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
test: skip irrelevant test on Windows
abbc279 
Skip test-cluster-disconnect-handles on Windows.

PR-URL: nodejs/node#12261
Ref: nodejs/node#12197 (comment)
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott deleted the fix-ci branch January 13, 2022 22:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hybrist hybrist approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL