FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

(v7.x backport) test: add more and refactor test cases to net.connect by joyeecheung · Pull Request #12325 · nodejs/node · GitHub

/ node Public

(v7.x backport) test: add more and refactor test cases to net.connect - #12325

Closed
joyeecheung wants to merge 1 commit into
nodejs:v7.x-stagingfrom
joyeecheung:backport-11847-to-v7.x
ConversationCommits (1)ChecksFiles changed
Closed

(v7.x backport) test: add more and refactor test cases to net.connect#12325
joyeecheung wants to merge 1 commit into
nodejs:v7.x-stagingfrom
joyeecheung:backport-11847-to-v7.x

Conversation

joyeecheung commented Apr 11, 2017

Copy link
Copy Markdown
Member

PR-URL: #11847

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

nodejs-github-bot added test Issues and PRs related to the tests. v7.x labels Apr 11, 2017

joyeecheung commented Apr 11, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/7324/

mscdex added the net Issues and PRs related to the net subsystem. label Apr 11, 2017

joyeecheung commented May 10, 2017

Copy link
Copy Markdown
Member Author

This needs review..Ping @nodejs/release @jasnell

joyeecheung commented May 10, 2017

Copy link
Copy Markdown
Member Author

New CI: https://ci.nodejs.org/job/node-test-pull-request/7988/

Trott commented Jul 15, 2017

Copy link
Copy Markdown
Member

Unfortunately, there are no more 7.x releases planned. Sorry this was never landed! I'm going to close it now.

Trott closed this Jul 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL