FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: replace IsConstructCall functions with lamda by danbev · Pull Request #12384 · nodejs/node · GitHub

/ node Public

src: replace IsConstructCall functions with lamda - #12384

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:cares_wrap-lamda
ConversationCommits (1)ChecksFiles changed
Closed

src: replace IsConstructCall functions with lamda#12384
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:cares_wrap-lamda

Conversation

danbev commented Apr 13, 2017

Copy link
Copy Markdown
Contributor

I noticed that there are three static functions that only check if
args is a construct call. This commit suggests replacing them and
them with a lamda.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. labels Apr 13, 2017

danbev commented Apr 13, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/7369/

bnoordhuis approved these changes Apr 13, 2017
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM modulo nits. Typo in commit log: s/lamda/lambda/

Comment thread src/cares_wrap.cc Outdated

bnoordhuis Apr 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Only two spaces of indent and call the variable is_construct_call (or is_construct_call_callback to indicate it's a function pointer.)

danbev Apr 13, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah again, must remember to not use camelcase 😞 Thanks!

danbev force-pushed the cares_wrap-lamda branch from 3fc1684 to ce11999 Compare April 13, 2017 10:20

danbev commented Apr 13, 2017

Copy link
Copy Markdown
Contributor Author

Rebased CI: https://ci.nodejs.org/job/node-test-pull-request/7372/

src: replace IsConstructCall functions with lambda
a440ec8 
I noticed that there are three static functions that only check if
args is a construct call. This commit suggests replacing them and
them with a lambda.
danbev force-pushed the cares_wrap-lamda branch from ce11999 to a440ec8 Compare April 15, 2017 10:27

danbev commented Apr 15, 2017

Copy link
Copy Markdown
Contributor Author

Rebased CI: https://ci.nodejs.org/job/node-test-pull-request/7415/

addaleax commented Apr 15, 2017

Copy link
Copy Markdown
Member

Landed in b280363

addaleax closed this Apr 15, 2017
addaleax pushed a commit that referenced this pull request Apr 15, 2017
src: replace IsConstructCall functions with lambda
b280363 
I noticed that there are three static functions that only check if
args is a construct call. This commit suggests replacing them and
them with a lambda.

PR-URL: #12384
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
danbev deleted the cares_wrap-lamda branch April 18, 2017 12:32
AndreasMadsen mentioned this pull request May 8, 2017
Closed
4 tasks
jasnell mentioned this pull request May 11, 2017
Closed
gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks

gibfahn commented Jun 18, 2017

Copy link
Copy Markdown
Member

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
jasnell jasnell approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL