FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

v6.x backport: test: refactor several parallel/test-timer tests by BethGriggs · Pull Request #12401 · nodejs/node · GitHub

/ node Public

v6.x backport: test: refactor several parallel/test-timer tests - #12401

Closed
BethGriggs wants to merge 1 commit into
nodejs:v6.x-stagingfrom
BethGriggs:backport-10524-to-v6.x
ConversationCommits (1)ChecksFiles changed
Closed

v6.x backport: test: refactor several parallel/test-timer tests#12401
BethGriggs wants to merge 1 commit into
nodejs:v6.x-stagingfrom
BethGriggs:backport-10524-to-v6.x

Conversation

BethGriggs commented Apr 13, 2017

Copy link
Copy Markdown
Member

Change var to const/let. Simplify test-timers-uncaught-exception.

PR-URL: #10524
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Gibson Fahnestock gibfahn@gmail.com
Reviewed-By: Jeremiah Senkpiel fishrock123@rocketmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Test

/cc @gibfahn

nodejs-github-bot added test Issues and PRs related to the tests. v6.x labels Apr 13, 2017

sam-github commented Apr 13, 2017

Copy link
Copy Markdown
Contributor

ci: https://ci.nodejs.org/job/node-test-pull-request/7381/

lpinca changed the title test: refactor several parallel/test-timer tests v6.x backport: test: refactor several parallel/test-timer tests Apr 13, 2017

lpinca commented Apr 13, 2017

Copy link
Copy Markdown
Member

@BethGriggs I took the liberty of updating PR title.

mscdex added timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. and removed backport-to-v6.x labels Apr 13, 2017

MylesBorins commented Apr 13, 2017

Copy link
Copy Markdown
Contributor

so it seems like the work from this PR ended up getting wrapped into another backport that has already landed. Thanks for putting the time into this @BethGriggs, fun to run into you in the PR tracker 😄

gibfahn commented Apr 18, 2017

Copy link
Copy Markdown
Member

@MylesBorins Is that true? The changes to the first file were just var->const, and they went into a different PR, but the changes to the other files don't seem to have gone into v6.x-staging, e.g. test-timers-uncaught-exception.js on v6.x-staging.

e.g. this diff:

-console.error('set first timer');
-setTimeout(function() {
-  console.error('first timer');
-  timer1++;
-  throw new Error('BAM!');
-}, 100);
+setTimeout(common.mustCall(function() {
+  throw new Error(errorMsg);
+}), 1);

isn't in test-timers-uncaught-exception.js#L10-L15.

gibfahn reopened this Apr 18, 2017
test: refactor several parallel/test-timer tests
6896e4c 
Change var to const/let. Simplify test-timers-uncaught-exception.

PR-URL: nodejs#10524
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
BethGriggs force-pushed the backport-10524-to-v6.x branch from 271e226 to 6896e4c Compare April 18, 2017 11:06

gibfahn commented Apr 18, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-commit/9193/

gibfahn commented Apr 19, 2017

Copy link
Copy Markdown
Member

CI 2: https://ci.nodejs.org/job/node-test-commit/9241/

MylesBorins pushed a commit that referenced this pull request Apr 24, 2017
test: refactor several parallel/test-timer tests
9218661 
Change var to const/let. Simplify test-timers-uncaught-exception.

Backport-PR-URL: #12401
PR-URL: #10524
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins commented Apr 24, 2017

Copy link
Copy Markdown
Contributor

landed in 9218661

MylesBorins pushed a commit that referenced this pull request Apr 24, 2017
test: refactor several parallel/test-timer tests
aae3765 
Change var to const/let. Simplify test-timers-uncaught-exception.

Backport-PR-URL: #12401
PR-URL: #10524
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
test: refactor several parallel/test-timer tests
1078086 
Change var to const/let. Simplify test-timers-uncaught-exception.

Backport-PR-URL: nodejs/node#12401
PR-URL: nodejs/node#10524
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
BethGriggs deleted the backport-10524-to-v6.x branch February 21, 2018 15:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
sam-github sam-github approved these changes
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL