FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "benchmark: fix CLI arguments check in common.js" by jasnell · Pull Request #12474 · nodejs/node · GitHub

/ node Public

Revert "benchmark: fix CLI arguments check in common.js" - #12474

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:revert-12429
ConversationCommits (1)ChecksFiles changed
Closed

Revert "benchmark: fix CLI arguments check in common.js"#12474
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:revert-12429

Conversation

jasnell commented Apr 17, 2017

Copy link
Copy Markdown
Member

Ugh. I goofed. I landed #12429, then realized it never went through CI and it breaks one of the tests in sequential.

This reverts commit e34f8e1.

Need to get this landed quickly so we unbreak CI

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, benchmark

nodejs-github-bot added the benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. label Apr 17, 2017

jasnell commented Apr 17, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/7460/

MylesBorins approved these changes Apr 17, 2017
View reviewed changes

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

rubberstamp LGTM if it fixes CI

jasnell added a commit that referenced this pull request Apr 17, 2017
Revert "benchmark: fix CLI arguments check in common.js"
0227571 
This reverts commit e34f8e1.

PR-URL: #12474
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell commented Apr 17, 2017

Copy link
Copy Markdown
Member Author

Landed.

jasnell closed this Apr 17, 2017
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
Revert "benchmark: fix CLI arguments check in common.js"
14b4205 
This reverts commit e34f8e1.

PR-URL: #12474
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas mentioned this pull request May 1, 2017
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
Revert "benchmark: fix CLI arguments check in common.js"
443147d 
This reverts commit e34f8e1.

PR-URL: #12474
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas pushed a commit that referenced this pull request May 2, 2017
Revert "benchmark: fix CLI arguments check in common.js"
440f4d4 
This reverts commit e34f8e1.

PR-URL: #12474
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

gibfahn commented May 16, 2017

Copy link
Copy Markdown
Member

dont-land-on-v6.x as it depends on #7094 (via #12429) which was semver-major.

baby636 mentioned this pull request Jun 22, 2022
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
+1 more reviewer
MylesBorins MylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL