FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add inspect-brk option to cluster module by dave-k · Pull Request #12503 · nodejs/node · GitHub

/ node Public

test: add inspect-brk option to cluster module - #12503

Closed
dave-k wants to merge 4 commits into
nodejs:masterfrom
dave-k:1140_test_cluster_inspect-brk
ConversationCommits (4)ChecksFiles changed
Closed

test: add inspect-brk option to cluster module#12503
dave-k wants to merge 4 commits into
nodejs:masterfrom
dave-k:1140_test_cluster_inspect-brk

Conversation

dave-k commented Apr 19, 2017

Copy link
Copy Markdown
Contributor

Ensure that cluster interoperates with the --inspect-brk option.
This does not test for —debug-brk.

Fixes: #11420

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test cluster

test: add inspect-brk option to cluster module
7260dd5 
Ensure that cluster interoperates with the --inspect-brk option.
This does not test for —debug-brk.

Fixes: nodejs#11420
nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 19, 2017
hiroppy added the cluster Issues and PRs related to the cluster subsystem. label Apr 19, 2017
benjamingr approved these changes Apr 19, 2017
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Slightly confusing way to write this - but still LGTM.

cjihrig commented Apr 19, 2017

Copy link
Copy Markdown
Contributor

It might be helpful to have the cluster worker print something or crash. Then, you can test that it doesn't happen because the worker is at a breakpoint.

test: assert fail if breakpoint not reached
61d06c5 
Have the cluster worker print something or crash.
Then, test that it doesn't happen
because the worker is at a breakpoint.
cjihrig requested changes Apr 19, 2017
View reviewed changes
Comment thread test/parallel/test-cluster-inspect-brk.js Outdated
test([`--inspect-brk=${debuggerPort}`]);
} else {
// Cluster worker is at a breakpoint, should not reach here.
assert.fail(1, 2, 'Test failed: cluster worker is at a breakpoint.', '>');

cjihrig Apr 19, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

As of recently, this can just be:

assert.fail('Test failed: cluster worker is at a breakpoint.');

dave-k commented Apr 20, 2017

Copy link
Copy Markdown
Contributor Author

Are the requested changes OK?

cjihrig approved these changes Apr 20, 2017
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if the CI is good. However, because this test uses common.PORT, it should probably be moved from parallel to sequential.

dave-k commented Apr 24, 2017

Copy link
Copy Markdown
Contributor Author

Can this proceed or does the test need to be moved from parallel to sequential?

cjihrig commented Apr 25, 2017

Copy link
Copy Markdown
Contributor

I would move it to sequential as long as common.PORT is there.

test: move test from parallel to sequential
c8f4d11 
because this test uses common.PORT, moved from parallel to sequential.

cjihrig commented Apr 25, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/7672/

addaleax commented Apr 29, 2017

Copy link
Copy Markdown
Member

Landed in 0324ac6

addaleax closed this Apr 29, 2017
addaleax pushed a commit that referenced this pull request Apr 29, 2017
test: add inspect-brk option to cluster module
0324ac6 
Ensure that cluster interoperates with the --inspect-brk option.
This does not test for --debug-brk.

Fixes: #11420
PR-URL: #12503
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell mentioned this pull request May 11, 2017
Closed
gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks

gibfahn commented Jun 18, 2017

Copy link
Copy Markdown
Member

Should land with #12615 if that lands

gibfahn mentioned this pull request Jun 18, 2017
Closed
3 tasks
MylesBorins pushed a commit that referenced this pull request Oct 16, 2017
test: add inspect-brk option to cluster module
1de5797 
Ensure that cluster interoperates with the --inspect-brk option.
This does not test for --debug-brk.

Fixes: #11420
PR-URL: #12503
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Oct 17, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
test: add inspect-brk option to cluster module
7b9710d 
Ensure that cluster interoperates with the --inspect-brk option.
This does not test for --debug-brk.

Fixes: #11420
PR-URL: #12503
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Nov 3, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement a test to ensure that cluster properly interoperates with the --{inspect,debug}-brk options

8 participants

Back | FazBrowse Home | New Git URL