deps: cherry-pick e560815 from upstream v8 - #12779
Conversation
Sorry, something went wrong.
mhdawson
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Original commit message: [runtime] Fix Array.prototype.concat with complex @@species Array.prototype.concat does not properly handle JSProxy species that will modify the currently visited array. BUG=682194 Review-Url: https://codereview.chromium.org/2655623004 Cr-Commit-Position: refs/heads/master@{nodejs#42640} PR-URL: nodejs#12779 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: targos - Michaël Zasso <targos@protonmail.com> Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: mhdawson - Michael Dawson <michael_dawson@ca.ibm.com>
|
Thanks. Landed on v7.x-staging as 57c0e71. |
Sorry, something went wrong.
Original commit message: [runtime] Fix Array.prototype.concat with complex @@species Array.prototype.concat does not properly handle JSProxy species that will modify the currently visited array. BUG=682194 Review-Url: https://codereview.chromium.org/2655623004 Cr-Commit-Position: refs/heads/master@{nodejs#42640} PR-URL: Refs: nodejs#12779
|
Removing label lts-watch-v6.x as I have opened #16133 for v6.x @nodejs/lts note that the process for auditing potential backports for 6.x failed for this one. This was originally fixed in May 11 but never ported back to v6.x. I suspect this is because this bugfix never landed on master because it was not needed there. How do prevent issues like this from leaking? Do we need an audit of all issues still tagged with lts-watch-v6.x? |
Sorry, something went wrong.
I think branch-diff didn't catch this because it never went into a 7.x release. I guess it might make sense to check v7.x-staging after v7.x goes EoL. Here's the command we currently use: branch-diff v6.x-staging upstream/v7.x --exclude-label semver-major,semver-minor,dont-land-on-v6.x,backport-requested-v6.x,backported-to-v6.x,baking-for-lts --reverse --filter-release Raw |
Sorry, something went wrong.
Original commit message: [runtime] Fix Array.prototype.concat with complex @@species Array.prototype.concat does not properly handle JSProxy species that will modify the currently visited array. BUG=682194 Review-Url: https://codereview.chromium.org/2655623004 Cr-Commit-Position: refs/heads/master@{#42640} Refs: #12779 PR-URL: #16133 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original commit message: [runtime] Fix Array.prototype.concat with complex @@species Array.prototype.concat does not properly handle JSProxy species that will modify the currently visited array. BUG=682194 Review-Url: https://codereview.chromium.org/2655623004 Cr-Commit-Position: refs/heads/master@{#42640} Refs: #12779 PR-URL: #16133 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original commit message:
This is already fixed on V8 5.7 and 5.8. Needs to be fixed on V8 5.5 (Node 7) and V8 5.1 (Node 6).
Checklist
Affected core subsystem(s)
deps:v8
CI: https://ci.nodejs.org/job/node-test-pull-request/7781/
V8 CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/675/