FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add a simple abort check in windows by sreepurnajasti · Pull Request #12914 · nodejs/node · GitHub

/ node Public

test: add a simple abort check in windows - #12914

Closed
sreepurnajasti wants to merge 1 commit into
nodejs:masterfrom
sreepurnajasti:windowsabortcheck
ConversationCommits (1)ChecksFiles changed
Closed

test: add a simple abort check in windows#12914
sreepurnajasti wants to merge 1 commit into
nodejs:masterfrom
sreepurnajasti:windowsabortcheck

Conversation

sreepurnajasti commented May 9, 2017

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Working with @gireeshpunathil, I came up with this PR following @refack's suggestion
in #12856 . Though associated with that, this test is logically independent of that PR,
and does not need to co-exist with that one, and hence a separate one.

Make a simple assertion that Windows aborts with exit code 3.

nodejs-github-bot added the test Issues and PRs related to the tests. label May 9, 2017
mscdex added the windows Issues and PRs related to the Windows platform. label May 9, 2017

mscdex commented May 9, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/7956/

gibfahn commented May 9, 2017

Copy link
Copy Markdown
Member

This looks great, if you could add a two line summary of what the test tests that would be ideal (see the writing tests guide).

sreepurnajasti commented May 9, 2017

Copy link
Copy Markdown
Contributor Author

@gibfahn Done. Added summary. Thanks

cjihrig approved these changes May 9, 2017
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with a couple nits.

Comment thread test/parallel/test-windows-abort-exitcode.js Outdated

cjihrig May 9, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit, but could you use process.execPath and __filename instead of the argv values? I think it's a little more readable.

sreepurnajasti May 10, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done.

Comment thread test/parallel/test-windows-abort-exitcode.js Outdated

cjihrig May 9, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

in windows -> on Windows

sreepurnajasti May 10, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done. Thanks.

Comment thread test/parallel/test-windows-abort-exitcode.js Outdated

cjihrig May 9, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You can probably drop the last sentence.

sreepurnajasti May 10, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done.

jasnell approved these changes May 9, 2017
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with @cjihrig's comments addressed.

test: add a simple abort check in windows
8c2cc9a 
raise(SIGABRT) or CRT abort causes exit code 3 and
null signal in windows. Looks like this simple assertion
is not present in windows. Make this assertion.

refack commented May 12, 2017

Copy link
Copy Markdown
Contributor

Landed in 642bd4d

refack closed this May 12, 2017
refack pushed a commit that referenced this pull request May 12, 2017
test: add a simple abort check in windows
642bd4d 
raise(SIGABRT) or CRT abort causes exit code 3 and
null signal in windows. Looks like this simple assertion
is not present in windows. Make this assertion.

PR-URL: #12914
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

refack commented May 12, 2017

Copy link
Copy Markdown
Contributor

post land CI:https://ci.nodejs.org/job/node-test-commit/9853/

anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
test: add a simple abort check in windows
b4407ef 
raise(SIGABRT) or CRT abort causes exit code 3 and
null signal in windows. Looks like this simple assertion
is not present in windows. Make this assertion.

PR-URL: nodejs#12914
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell mentioned this pull request May 28, 2017
Closed
gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks

MylesBorins commented Jun 22, 2017

Copy link
Copy Markdown
Contributor

does this make sense for v6.x?

refack commented Jun 22, 2017

Copy link
Copy Markdown
Contributor

does this make sense for v6.x?

Yes. (just checked it passes as is).

bnoordhuis mentioned this pull request Jun 29, 2017
Closed
3 tasks
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
test: add a simple abort check in windows
0c83573 
raise(SIGABRT) or CRT abort causes exit code 3 and
null signal in windows. Looks like this simple assertion
is not present in windows. Make this assertion.

PR-URL: #12914
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Jul 18, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
gireeshpunathil gireeshpunathil approved these changes
+3 more reviewers
refack refack approved these changes
thefourtheye thefourtheye approved these changes
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL