FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: whitelist new options for NODE_OPTIONS by sam-github · Pull Request #13002 · nodejs/node · GitHub

/ node Public

src: whitelist new options for NODE_OPTIONS - #13002

Merged
sam-github merged 1 commit into
nodejs:masterfrom
sam-github:add-inspect-to-node-options
May 17, 2017
ConversationCommits (1)ChecksFiles changed
Merged

src: whitelist new options for NODE_OPTIONS#13002
sam-github merged 1 commit into
nodejs:masterfrom
sam-github:add-inspect-to-node-options

Conversation

sam-github commented May 12, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add --inspect-port, --napi-modules, --trace-event-categories

Remove --prof-process, like -p and -e, it causes node to do something
other than run node js scripts.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

src

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 12, 2017
sam-github mentioned this pull request May 12, 2017
Closed

sam-github commented May 12, 2017

Copy link
Copy Markdown
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/8046/

refack approved these changes May 12, 2017
View reviewed changes
Comment thread doc/api/cli.md Outdated

refack May 12, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You must have had a reason to leave those out on the first run?
They will make a very weird effect...
inspect-port on the other hand is benign if used alone.

sam-github May 12, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Useful when running node via a shell script, and wanting to cause node when it runs to break on first line. I'm not sure how much thought went into this initially. I can leave only the -port if that's preferred.

refack May 12, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm ±0 on these.

sam-github May 12, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

ok, I'll give it a couple days to see if anyone feels strongly

gibfahn May 12, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Seems useful to have, although if the node process spawns a child will that child also try to connect to the inspector?

sam-github May 16, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

yes, so don't do that unless the port is 0

refack commented May 12, 2017

Copy link
Copy Markdown
Contributor

Ignore the fail on macOS (and maybe freeBSD) they are flakes #12964 (comment)

mscdex added the cli Issues and PRs related to the Node.js command line interface. label May 13, 2017

Trott commented May 14, 2017

Copy link
Copy Markdown
Member

No idea if it would be difficult to accomplish or not, but a test for #12941 (assuming this fixes that issue) would be great.

Or at least some kind of test for the functionality change here?

sam-github commented May 16, 2017

Copy link
Copy Markdown
Contributor Author

@Trott #12941 is a different bug, something is wrong in the cluster pre-fork arg parsing, unrelated (though perhaps this could be used as work-around)

refack commented May 16, 2017

Copy link
Copy Markdown
Contributor

If this lands before #12949 I can add tests for --inspect, --inspect-brk, and --inspect-port

sam-github commented May 16, 2017

Copy link
Copy Markdown
Contributor Author

I removed support for --inspect, --inspect-brk, adding unit tests for every option passed via env var is a bit more than I can manage. I might remove support for --trace-event-categories as well, node has the unfortunate habit of randomly requiring either a = or a before an option's value :-(, but I'm trying harder for it because trace events are absolutely the kind of thing I'd want to configure via env var.

sam-github force-pushed the add-inspect-to-node-options branch 2 times, most recently from 39ccc51 to 2472f17 Compare May 16, 2017 21:52
refack suggested changes May 16, 2017
View reviewed changes

refack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit

Comment thread doc/api/cli.md Outdated

refack May 16, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

"--inspect-port"

refack mentioned this pull request May 16, 2017
Closed
sam-github force-pushed the add-inspect-to-node-options branch from 0d3f956 to d6ce121 Compare May 16, 2017 23:02
mhdawson approved these changes May 17, 2017
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

sam-github force-pushed the add-inspect-to-node-options branch from d6ce121 to 42d7e61 Compare May 17, 2017 17:11

sam-github commented May 17, 2017

Copy link
Copy Markdown
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/8131/

sam-github commented May 17, 2017

Copy link
Copy Markdown
Contributor Author

Only failure was unrelated, sequential/test-net-connect-local-error on one of the FreeBSDs, I'm going to land this.

src: whitelist new options for NODE_OPTIONS
d6cd466 
Add --inspect-*, --napi-modules, --trace-event-categories

Remove --prof-process, like -p and -e, it causes node to do something
other than run node js scripts.

PR-URL: nodejs#13002
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
sam-github force-pushed the add-inspect-to-node-options branch from 42d7e61 to d6cd466 Compare May 17, 2017 19:40
sam-github merged commit d6cd466 into nodejs:master May 17, 2017
sam-github deleted the add-inspect-to-node-options branch May 17, 2017 19:42
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
src: whitelist new options for NODE_OPTIONS
17a4a5f 
Add --inspect-*, --napi-modules, --trace-event-categories

Remove --prof-process, like -p and -e, it causes node to do something
other than run node js scripts.

PR-URL: nodejs#13002
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jasnell mentioned this pull request May 28, 2017
Closed
sam-github mentioned this pull request May 30, 2017
Closed
4 tasks

sam-github commented May 30, 2017

Copy link
Copy Markdown
Contributor Author

See #12677

refack mentioned this pull request Jun 11, 2017
Closed
gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks

MylesBorins commented Jun 23, 2017

Copy link
Copy Markdown
Contributor

I've added don't land for v6.x

If any of these flags should be backported please feel free to open a separate PR

sam-github commented Jul 25, 2017

Copy link
Copy Markdown
Contributor Author

backported in #12677

sam-github added a commit to sam-github/node that referenced this pull request Oct 11, 2017
src: whitelist new options for NODE_OPTIONS
d6a584b 
Add --debug-*, --napi-modules

Remove --prof-process, like -p and -e, it causes node to do something
other than run node js scripts.

PR-URL: nodejs#13002
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Oct 16, 2017
src: whitelist new options for NODE_OPTIONS
9c0f734 
Add --debug-*, --napi-modules

Remove --prof-process, like -p and -e, it causes node to do something
other than run node js scripts.

Backport-PR-URL: #12677
PR-URL: #13002
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins mentioned this pull request Oct 17, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
src: whitelist new options for NODE_OPTIONS
12b66e6 
Add --debug-*, --napi-modules

Remove --prof-process, like -p and -e, it causes node to do something
other than run node js scripts.

Backport-PR-URL: #12677
PR-URL: #13002
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins mentioned this pull request Nov 3, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
+3 more reviewers
gibfahn gibfahn left review comments
refack refack approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. cli Issues and PRs related to the Node.js command line interface.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL