doc: document method for reverting commits - #13015
Merged
gibfahn merged 1 commit intoMay 16, 2017
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
cjihrig
approved these changes
May 13, 2017
cjihrig
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM with a suggestion.
Sorry, something went wrong.
Comment thread
COLLABORATOR_GUIDE.md
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
A subsection header might be appropriate here.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Done
Sorry, something went wrong.
Trott
approved these changes
May 13, 2017
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
joyeecheung
reviewed
May 14, 2017
joyeecheung
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Probably a bit obvious but...should we mention that we do need to open PRs for reverting commits?
Sorry, something went wrong.
lpinca
approved these changes
May 14, 2017
Copy link
Copy Markdown
Member
Author
@joyeecheung why not! Done |
Sorry, something went wrong.
benjamingr
approved these changes
May 14, 2017
joyeecheung
approved these changes
May 14, 2017
jasnell
approved these changes
May 15, 2017
PR-URL: nodejs#13015 Fixes: nodejs#12979 Refs: nodejs#4679 (comment) Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 19, 2017
PR-URL: nodejs#13015 Fixes: nodejs#12979 Refs: nodejs#4679 (comment) Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jun 22, 2017
PR-URL: #13015 Fixes: #12979 Refs: #4679 (comment) Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2017
PR-URL: #13015 Fixes: #12979 Refs: #4679 (comment) Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #12979
Refs: #4679 (comment)
Checklist
Affected core subsystem(s)
doc