(7.x backport) NODE_OPTIONS, and one of its dependant refactors - #13063
Merged
sam-github merged 2 commits intoMay 19, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
A dynamically allocated array was being used, simplify the memory management by using std::vector. PR-URL: nodejs#12241 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
sam-github
force-pushed
the
backport-12241-use-vector-for-preload-modules
branch
from
9a8f38e to
3ab322f
Compare
May 18, 2017 16:19
Not all CLI options are supported, those that are problematic from a security or implementation point of view are disallowed, as are ones that are inappropriate (for example, -e, -p, --i), or that only make sense when changed with code changes (such as options that change the javascript syntax or add new APIs). PR-URL: nodejs#12028 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
sam-github
force-pushed
the
backport-12241-use-vector-for-preload-modules
branch
from
3ab322f to
3f6199c
Compare
May 18, 2017 16:30
4 tasks
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
gibfahn
approved these changes
May 19, 2017
Copy link
Copy Markdown
Contributor
Author
|
@nodejs/release How do things land on v7.x-staging? Can I land this? Does someone from release? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Hm, @gibfahn points out that people seem to land themselves: https://github.com/nodejs/node/pulls?utf8=%E2%9C%93&q=is%3Apr%20is%3Aclosed%20base%3Av7.x-staging%20 So, I will. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12241 to 7.x
Also rolled in #12648, because it depends on the use of std::vector.
A dynamically allocated array was being used, simplify the memory
management by using std::vector.
PR-URL: #12241
Reviewed-By: Richard Lau riclau@uk.ibm.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Daniel Bevenius daniel.bevenius@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net
Checklist
Affected core subsystem(s)