FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http: describe parse err in debug output by sam-github · Pull Request #13206 · nodejs/node · GitHub

/ node Public

http: describe parse err in debug output - #13206

Closed
sam-github wants to merge 1 commit into
nodejs:masterfrom
sam-github:describe-parse-error
ConversationCommits (1)ChecksFiles changed
Closed

http: describe parse err in debug output#13206
sam-github wants to merge 1 commit into
nodejs:masterfrom
sam-github:describe-parse-error

Conversation

sam-github commented May 24, 2017

Copy link
Copy Markdown
Contributor

parse errors are fairly invisible on the server, even with NODE_DEBUG, the actuall error is not reported, just that one ocurred. This patch helped me a lot.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

http

nodejs-github-bot added the http Issues or PRs related to the http subsystem. label May 24, 2017
sam-github requested a review from mscdex May 24, 2017 20:19

mscdex commented May 24, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

That's fine I suppose, you should probably add it in _http_client.js also for consistency.

sam-github commented May 24, 2017

Copy link
Copy Markdown
Contributor Author

@mscdex done

mscdex commented May 24, 2017

Copy link
Copy Markdown
Contributor

LGTM.

sam-github force-pushed the describe-parse-error branch from fb1def3 to 6d3b451 Compare May 24, 2017 20:59

sam-github commented May 24, 2017

Copy link
Copy Markdown
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/8293/

jasnell pushed a commit that referenced this pull request Jun 1, 2017
http: describe parse err in debug output
3fba3d6 
PR-URL: #13206
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

jasnell commented Jun 1, 2017 •
edited by refack
Loading

Copy link
Copy Markdown
Member

Landed in 3ffba3d6 3fba3d6

jasnell closed this Jun 1, 2017
jasnell reopened this Jun 1, 2017
jasnell closed this Jun 1, 2017
jasnell reopened this Jun 1, 2017

jasnell commented Jun 1, 2017

Copy link
Copy Markdown
Member

eh... no idea what just happened right there.

jasnell closed this Jun 1, 2017

refack commented Jun 1, 2017

Copy link
Copy Markdown
Contributor

edited commit hash

jasnell pushed a commit that referenced this pull request Jun 5, 2017
http: describe parse err in debug output
b3c9bff 
PR-URL: #13206
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
jasnell mentioned this pull request Jun 5, 2017
Closed
sam-github deleted the describe-parse-error branch June 14, 2017 20:35
gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks

MylesBorins commented Jul 17, 2017

Copy link
Copy Markdown
Contributor

Should this be backported to v6.x?

sam-github added a commit to sam-github/node that referenced this pull request Jul 21, 2017
http: describe parse err in debug output
cf8045a 
PR-URL: nodejs#13206
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
sam-github mentioned this pull request Jul 21, 2017
Closed
4 tasks

sam-github commented Jul 21, 2017

Copy link
Copy Markdown
Contributor Author

@MylesBorins yes, and I did.

MylesBorins pushed a commit that referenced this pull request Jul 21, 2017
http: describe parse err in debug output
71e542c 
Backport-PR-URL: #14416
PR-URL: #13206
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins mentioned this pull request Jul 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Jul 31, 2017
http: describe parse err in debug output
f66f09f 
Backport-PR-URL: #14416
PR-URL: #13206
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins added a commit that referenced this pull request Aug 1, 2017
2017-08-01, Version 6.11.2 'Boron' (LTS)
f15e124 
This LTS release comes with 221 commits. This includes 80 which are
test related, 52 which are doc related, 32 which are build / tool
related and 10 commits which are updates to dependencies.

Notable Changes:

* configure:
  - add mips64el to valid_arch (Aditya Anand)
    - #13620
* crypto:
  - Updated root certificates based on [NSS 3.30] (Ben Noordhuis)
    - #13279
    - #12402
    - https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.30_release_notes
* deps:
  - upgrade OpenSSL to version 1.0.2.l (Shigeki Ohtsu)
    - #12913
* http:
  - parse errors are now reported when NODE_DEBUG=http (Sam Roberts)
    - #13206
  - Agent construction can now be envoked without `new` (cjihrig)
    - #12927
* zlib:
  - node will now throw an Error when zlib rejects the value of windowBits,
    instead of crashing (Alexey Orlenko)
    - #13098

PR-URL: #14356
MylesBorins added a commit that referenced this pull request Aug 1, 2017
2017-08-01, Version 6.11.2 'Boron' (LTS)
8a53897 
This LTS release comes with 221 commits. This includes 80 which are
test related, 52 which are doc related, 32 which are build / tool
related and 10 commits which are updates to dependencies.

Notable Changes:

* configure:
  - add mips64el to valid_arch (Aditya Anand)
    - #13620
* crypto:
  - Updated root certificates based on [NSS 3.30] (Ben Noordhuis)
    - #13279
    - #12402
    - https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.30_release_notes
* deps:
  - upgrade OpenSSL to version 1.0.2.l (Shigeki Ohtsu)
    - #12913
* http:
  - parse errors are now reported when NODE_DEBUG=http (Sam Roberts)
    - #13206
  - Agent construction can now be envoked without `new` (cjihrig)
    - #12927
* zlib:
  - node will now throw an Error when zlib rejects the value of windowBits,
    instead of crashing (Alexey Orlenko)
    - #13098

PR-URL: #14356
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
mscdex Awaiting requested review from mscdex
+1 more reviewer
refack refack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

http Issues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL