FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

util: refactor util module by jasnell · Pull Request #13803 · nodejs/node · GitHub

/ node Public

util: refactor util module - #13803

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:refactor-util
ConversationCommits (1)ChecksFiles changed
Closed

util: refactor util module#13803
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:refactor-util

Conversation

jasnell commented Jun 19, 2017

Copy link
Copy Markdown
Member

Refactor util module

  • Use module.exports pattern (but preserve exports = also so monkeypatching still works)
  • Early capture of prototype methods
  • More consistent use of template strings and ...args
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

util

nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Jun 19, 2017
jasnell changed the title Refactor util util: refactor util module Jun 19, 2017
evanlucas reviewed Jun 19, 2017
View reviewed changes
Comment thread lib/util.js Outdated

evanlucas Jun 19, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should the .Buffer be removed here?

jasnell Jun 19, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No, isBuffer is a property of Buffer

evanlucas Jun 20, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh wow yea. Disregard.

aqrln approved these changes Jun 21, 2017
View reviewed changes
Comment thread lib/util.js Outdated

aqrln Jun 21, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not sure it improves readability in this specific case, but LGTM either way.

aqrln commented Jun 21, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/8767/

util: refactor util module
674207f 
* refactor util exports
* early capture of prototype methods
* use template strings and args consistently

jasnell commented Jul 18, 2017

Copy link
Copy Markdown
Member Author

Rebased... updated.

jasnell commented Jul 24, 2017

Copy link
Copy Markdown
Member Author

New CI: https://ci.nodejs.org/job/node-test-pull-request/9313/

jasnell added a commit that referenced this pull request Jul 24, 2017
util: refactor util module
b1355ba 
* refactor util exports
* early capture of prototype methods
* use template strings and args consistently

PR-URL: #13803
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell commented Jul 24, 2017

Copy link
Copy Markdown
Member Author

Landed in b1355ba

jasnell closed this Jul 24, 2017

addaleax commented Jul 24, 2017

Copy link
Copy Markdown
Member

This doesn’t land cleanly on 8.x; if you can, please follow the guide and raise a backport PR.

jasnell commented Jul 24, 2017

Copy link
Copy Markdown
Member Author

Unless it ends up causing backport pains for other PRs, this likely isn't a priority to backport.

addaleax commented Jul 24, 2017

Copy link
Copy Markdown
Member

Okay, I’ve switched to dont-land. I’m still a bit worried with Node 8 ending LTS in almost 2 years, and we already have a lot of backporting pain…

jasnell commented Aug 1, 2017

Copy link
Copy Markdown
Member Author

Actually.. I'm going to do a backport for this, it does interfere with backporting another one. Sigh.

jasnell added a commit to jasnell/node that referenced this pull request Aug 1, 2017
util: refactor util module
7a3f0ef 
* refactor util exports
* early capture of prototype methods
* use template strings and args consistently

PR-URL: nodejs#13803
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell mentioned this pull request Aug 1, 2017
Closed
4 tasks
addaleax pushed a commit that referenced this pull request Aug 2, 2017
util: refactor util module
f593960 
* refactor util exports
* early capture of prototype methods
* use template strings and args consistently

Backport-PR-URL: #14585
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #13803
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax mentioned this pull request Aug 2, 2017
Merged

MylesBorins commented Aug 16, 2017

Copy link
Copy Markdown
Contributor

@jasnell LTS?

jasnell commented Aug 16, 2017

Copy link
Copy Markdown
Member Author

Not unless it's blocking anything.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes
+2 more reviewers
evanlucas evanlucas left review comments
aqrln aqrln approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL