| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Maybe we should create an official end of life deprecation entry before removing. @jasnell WDYT? |
Sorry, something went wrong.
|
Yep, I agree. Let's mark it end of life in docs/api/deprecations.md in 9.0 and look to remove in 10.0. |
Sorry, something went wrong.
|
@cjihrig @jasnell is this really necessary in this case? The old format would immediately be migrated to the new format by starting the repl. So it's a one time process for each user that specifically used io.js 2 and it was already deprecated in io.js 3. It is a history file so would anyone want to rely on a history file that would be two years old? |
Sorry, something went wrong.
Since it's a low-risk/low-reward situation, I believe going by the book is just safer... So we'll need to mark it EOL in the docs. |
Sorry, something went wrong.
|
Agree. Let's mark it EOL in 9.x |
Sorry, something went wrong.
|
I rebased this and even though the run-time deprecation did not yet land, I personally feel like it is absolutely fine to directly go to the end-of-life as this does not hurt anyone even in the very unlikely case that someone still uses io.js 2.x and directly updates to 10.x. |
Sorry, something went wrong.
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
PR-URL: nodejs#13876 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#13876 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
| Back | FazBrowse Home | New Git URL |
This is a alternative to #13733
The history file was only active in io.js 2.x and was deprecated in io.js 3.0. I think it's safe to remove this instead of fixing the error handling but I thought having both here to decide on is the best to do.
I'll finish the tests if it's decided that it should be removed instead of fixed.
Checklist
Affected core subsystem(s)
repl