FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add note about python installer by refack · Pull Request #13881 · nodejs/node · GitHub

/ node Public

doc: add note about python installer - #13881

Closed
refack wants to merge 1 commit into
nodejs:masterfrom
refack:building-with-python
ConversationCommits (1)ChecksFiles changed
Closed

doc: add note about python installer#13881
refack wants to merge 1 commit into
nodejs:masterfrom
refack:building-with-python

Conversation

refack commented Jun 22, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Ref: nodejs/CTC#147 (comment)

Checklist
Affected core subsystem(s)

doc,meta

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Jun 22, 2017
refack added the meta Issues and PRs related to the general management of the project. label Jun 22, 2017
vsemozhetbyt reviewed Jun 22, 2017
View reviewed changes
Comment thread BUILDING.md

* [Python 2.6 or 2.7](https://www.python.org/downloads/)
* [Python 2.6 or 2.7](https://www.python.org/downloads/)
*Note*: It is recommanded to include the "Add python.exe to path" option

vsemozhetbyt Jun 22, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

recommanded -> recommended ?

Is it a too soft word? Does not build fail without this option?

refack Jun 22, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Personally I don't like installers, so I add it to %Path% manually.
Also there's PEP-0514 (#13882) which I also do manually 😊

vsemozhetbyt Jun 22, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

So maybe we should add a note about the alternative ("add it to %Path% manually") if the #13882 has any chance to not cover all the cases.

refack Jun 22, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

add a note about the alternative ("add it to %Path% manually")

🤔 I don't like "spoon feeding" devs, so I need to think about this.
P.S. The installer will register the installation so #13882 should cover that. (To avoid that I have a special tool that extracts msi files so I can xcopy the extracted files to where I like, and then I do what's necessary for my system to work.)

benjamingr Jun 23, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm fine with #13882 landing rather than this note.

I like spoon feeding devs when it comes to tooling (and not code) - I don't want the fact building is hard or unclear to prevent contributors from joining.

refack mentioned this pull request Jun 22, 2017
Closed
mscdex removed the meta Issues and PRs related to the general management of the project. label Jun 22, 2017
refack changed the title doc,meta: add note about python installer doc: add note about python installer Jun 22, 2017

refack commented Jun 28, 2017

Copy link
Copy Markdown
Contributor Author

Superseded by #13900

refack closed this Jun 28, 2017
refack deleted the building-with-python branch June 28, 2017 15:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr left review comments
+1 more reviewer
vsemozhetbyt vsemozhetbyt left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL