FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mark test-fs-readdir-ucs2 flaky by joaocgreis · Pull Request #13989 · nodejs/node · GitHub

/ node Public

test: mark test-fs-readdir-ucs2 flaky - #13989

Closed
joaocgreis wants to merge 1 commit into
nodejs:masterfrom
JaneaSystems:joaocgreis-H6T-fs-readdir-ucs2-flaky
ConversationCommits (1)ChecksFiles changed
Closed

test: mark test-fs-readdir-ucs2 flaky#13989
joaocgreis wants to merge 1 commit into
nodejs:masterfrom
JaneaSystems:joaocgreis-H6T-fs-readdir-ucs2-flaky

Conversation

joaocgreis commented Jun 29, 2017

Copy link
Copy Markdown
Member

Changes in our CI infra makes test-fs-readdir-ucs2 fail every run on Raspberry Pi (ref: nodejs/build#774 (comment)).

While we need to find a better solution, I suggest we mark the test as flaky to avoid having every run red because of this.

@nodejs/testing @nodejs/ctc any objection for fast tracking?

Ref: nodejs/build#774
Ref: #13986

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Test

nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 29, 2017
joaocgreis mentioned this pull request Jun 29, 2017
Closed
joaocgreis added the arm Issues and PRs related to the ARM architecture. label Jun 29, 2017

refack commented Jun 29, 2017

Copy link
Copy Markdown
Contributor

+1 for fast-tracking

joaocgreis commented Jun 29, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/view/All/job/node-test-pull-request/8875/

Landed in 47d1e12, fast tracked.

joaocgreis closed this Jun 29, 2017
joaocgreis added a commit that referenced this pull request Jun 29, 2017
test: mark test-fs-readdir-ucs2 flaky
47d1e12 
PR-URL: #13989
Reviewed-By: Refael Ackermann <refack@gmail.com>

refack commented Jun 29, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Just to see it pass (well, yellow) CI on master: https://ci.nodejs.org/job/node-test-commit/10826/
#13985 will turn in green again 🙏

joaocgreis commented Jun 29, 2017

Copy link
Copy Markdown
Member Author

#13985 will turn in green again 🙏

Isn't that for Alpine? This is unrelated, the CI will remain yellow, which makes sense to me since test-fs-readdir-ucs2 is a valid test and we're not getting results to it from the Pis.

refack commented Jun 29, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Isn't that for Alpine? This is unrelated, the CI will remain yellow, which makes sense to me since test-fs-readdir-ucs2 is a valid test and we're not getting results to it from the Pis.

Yes, right. 🤦‍♂️

addaleax mentioned this pull request Jun 29, 2017
Merged
addaleax pushed a commit that referenced this pull request Jun 29, 2017
test: mark test-fs-readdir-ucs2 flaky
e446015 
PR-URL: #13989
Reviewed-By: Refael Ackermann <refack@gmail.com>
refack added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jun 30, 2017
addaleax pushed a commit that referenced this pull request Jul 11, 2017
test: mark test-fs-readdir-ucs2 flaky
a03e90c 
PR-URL: #13989
Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
test: mark test-fs-readdir-ucs2 flaky
e5d32b8 
PR-URL: #13989
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 18, 2017
test: mark test-fs-readdir-ucs2 flaky
dce4a75 
PR-URL: #13989
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins mentioned this pull request Jul 18, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Jul 21, 2017
test: mark test-fs-readdir-ucs2 flaky
8a7f13b 
PR-URL: #13989
Reviewed-By: Refael Ackermann <refack@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
refack refack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

arm Issues and PRs related to the ARM architecture. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL