test: increase --stack-size to prevent child process failure on ARM - #14
Closed
rvagg wants to merge 1 commit into
Closed
test: increase --stack-size to prevent child process failure on ARM#14rvagg wants to merge 1 commit into
rvagg wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
On ARM, we get a "Maximum call stack size exceeded" when using require() in the child process, bump it up a bit to avoid the failures so we can test what we are actually after
Copy link
Copy Markdown
Member
|
Does it actually continue to do the same thing on x86 platforms after this? If yes - LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Another LGTM. 64k is, in retrospect, a little on the low side. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
yep, tested across all platforms, fixes ARM, everything else is as it was: https://jenkins-node-forward.nodesource.com/job/iojs+any-pr+multi/2/ |
Sorry, something went wrong.
rvagg
added a commit
that referenced
this pull request
Nov 29, 2014
On ARM, we get a "Maximum call stack size exceeded" when using require() in the child process, bump it up a bit to avoid the failures so we can test what we are actually after Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: #14
fhinkel
pushed a commit
to fhinkel/node
that referenced
this pull request
Mar 23, 2017
Update V8 to 4c9ba86294
4 tasks
This was referenced Mar 18, 2020
targos
referenced
this pull request
in targos/node
Apr 27, 2021
Original commit message:
Merged: Squashed multiple commits.
Merged: Prepare renaming "V8 Linux64 TSAN - concurrent marking" bot
Revision: 165d8f5b5ab5ba6fa19acd7ae6b17aa1a1b18428
Merged: [test] Remove entry of renamed builder
Revision: 375579f940b96224b2c525a6133650b760a5d865
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=neis@chromium.org
Change-Id: If7c8296c495d087c2e4dc6cde3512bc3f8a469fc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2418098
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/branch-heads/8.6@{#14}
Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1}
Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472}
Refs: v8/v8@33f4064
targos
added a commit
that referenced
this pull request
Apr 30, 2021
Original commit message:
Merged: Squashed multiple commits.
Merged: Prepare renaming "V8 Linux64 TSAN - concurrent marking" bot
Revision: 165d8f5b5ab5ba6fa19acd7ae6b17aa1a1b18428
Merged: [test] Remove entry of renamed builder
Revision: 375579f940b96224b2c525a6133650b760a5d865
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=neis@chromium.org
Change-Id: If7c8296c495d087c2e4dc6cde3512bc3f8a469fc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2418098
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/branch-heads/8.6@{#14}
Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1}
Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472}
Refs: v8/v8@33f4064
PR-URL: #38275
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is a bit odd as an architecture-specific problem, but on ARM, we get a Maximum call stack size exceeded when using require() in the child process. I've bumped it up a bit to avoid the failures so we can test what we are actually after--the stack size isn't actually part of what's being tested.
In both of these tests, the manifestation of the problem is in an SyntaxError: Unexpected end of input because the child processes don't end up pushing any stdout so there's nothing to JSON.parse(), only stderr with the stack trace.