FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: skip test-fs-readdir-ucs2 if no support by Trott · Pull Request #14029 · nodejs/node · GitHub

/ node Public

test: skip test-fs-readdir-ucs2 if no support - #14029

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-ucs2-test
ConversationCommits (1)ChecksFiles changed
Closed

test: skip test-fs-readdir-ucs2 if no support#14029
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-ucs2-test

Conversation

Trott commented Jul 1, 2017

Copy link
Copy Markdown
Member

If the filesystem does not support UCS2, do not run the test.

Fixes: #14028

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test fs

Trott added the wip Issues and PRs that are still a work in progress. label Jul 1, 2017
nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 1, 2017

Trott commented Jul 1, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/8919/

Trott commented Jul 1, 2017

Copy link
Copy Markdown
Member Author

Looks like it's working now. Removing the in progress label.

Trott removed the wip Issues and PRs that are still a work in progress. label Jul 1, 2017
Trott mentioned this pull request Jul 1, 2017
Closed
richardlau reviewed Jul 1, 2017
View reviewed changes
Comment thread test/parallel/test-fs-readdir-ucs2.js Outdated

richardlau Jul 1, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is e.code set? If so it might be better to test against it rather than the message.

Trott Jul 1, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Indeed. Will change.

Trott commented Jul 1, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/8921/

Trott mentioned this pull request Jul 2, 2017
Closed
3 tasks
test: skip test-fs-readdir-ucs2 if no support
f03541e 
If the filesystem does not support UCS2, do not run the test.

Fixes: nodejs#14028

Trott commented Jul 3, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/8966/

refack pushed a commit to refack/node that referenced this pull request Jul 4, 2017
test: skip test-fs-readdir-ucs2 if no support
4dd7d09 
If the filesystem does not support UCS2, do not run the test.

PR-URL: nodejs#14029
Fixes: nodejs#14028
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
refack self-assigned this Jul 4, 2017

refack commented Jul 4, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Landed in 4dd7d09
(I don't usually do cradle-robbing, but the red/yellow was bothering me on this fine 4th-of-July morning 🦅 💚 )

Extra CI for sanity of master: https://ci.nodejs.org/job/node-test-commit/10945/

refack closed this Jul 4, 2017

refack commented Jul 4, 2017

Copy link
Copy Markdown
Contributor

GGGGGGRRRRRRRRRRRR npm
https://ci.nodejs.org/job/node-test-binary-arm/9040/RUN_SUBSET=3,label=pi3-raspbian-jessie/

addaleax pushed a commit that referenced this pull request Jul 11, 2017
test: skip test-fs-readdir-ucs2 if no support
5f45165 
If the filesystem does not support UCS2, do not run the test.

PR-URL: #14029
Fixes: #14028
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax mentioned this pull request Jul 11, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
test: skip test-fs-readdir-ucs2 if no support
d288cf1 
If the filesystem does not support UCS2, do not run the test.

PR-URL: #14029
Fixes: #14028
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
test: skip test-fs-readdir-ucs2 if no support
e583e3b 
If the filesystem does not support UCS2, do not run the test.

PR-URL: #14029
Fixes: #14028
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Aug 15, 2017
test: skip test-fs-readdir-ucs2 if no support
c57a786 
If the filesystem does not support UCS2, do not run the test.

PR-URL: #14029
Fixes: #14028
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Trott added a commit to Trott/io.js that referenced this pull request Aug 15, 2017
test: skip test-fs-readdir-ucs2 if no support
f41047e 
If the filesystem does not support UCS2, do not run the test.

PR-URL: nodejs#14029
Fixes: nodejs#14028
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
test: skip test-fs-readdir-ucs2 if no support
175d46e 
If the filesystem does not support UCS2, do not run the test.

Backport-PR-URL: #14835
PR-URL: #14029
Fixes: #14028
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins mentioned this pull request Aug 16, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
test: skip test-fs-readdir-ucs2 if no support
46e4a02 
If the filesystem does not support UCS2, do not run the test.

Backport-PR-URL: #14835
PR-URL: #14029
Fixes: #14028
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
refack removed their assignment Oct 20, 2018
Trott deleted the fix-ucs2-test branch January 13, 2022 22:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes
+1 more reviewer
refack refack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

investigate failing test-fs-readdir-ucs2 on Raspberry Pi

7 participants

Back | FazBrowse Home | New Git URL