FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

path: fix normalize on directories with two dots by targos · Pull Request #14107 · nodejs/node · GitHub

/ node Public

path: fix normalize on directories with two dots - #14107

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:fix-path-normalize
ConversationCommits (1)ChecksFiles changed
Closed

path: fix normalize on directories with two dots#14107
targos wants to merge 1 commit into
nodejs:masterfrom
targos:fix-path-normalize

Conversation

targos commented Jul 6, 2017

Copy link
Copy Markdown
Member

Fixes: #14105

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

path

nodejs-github-bot added the path Issues and PRs related to the path subsystem. label Jul 6, 2017

targos commented Jul 6, 2017

Copy link
Copy Markdown
Member Author

It's probably not the best way to fix the issue.

/cc @mscdex

targos mentioned this pull request Jul 6, 2017
Closed

refack commented Jul 6, 2017

Copy link
Copy Markdown
Contributor

Ref: #13683 & #13738

refack reviewed Jul 6, 2017
View reviewed changes
Comment thread test/parallel/test-path.js Outdated

refack Jul 6, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could you add:

assert.strictEqual(path.win32.normalize('bar\\foo..\\..\\'), 'bar\\');
assert.strictEqual(path.win32.normalize('bar\\foo..\\..\\baz'), 'bar\\baz');
assert.strictEqual(path.win32.normalize('bar\\foo..\\'), 'bar\\foo..');

Or alternatively find the coverage

targos Jul 7, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

done

targos force-pushed the fix-path-normalize branch 2 times, most recently from eb9ff15 to 1250227 Compare July 7, 2017 09:18
refack approved these changes Jul 7, 2017
View reviewed changes

refack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM
We could probably refactor this whole thing for TF&I anyway

mscdex commented Jul 7, 2017

Copy link
Copy Markdown
Contributor

We could probably refactor this whole thing for TF&I anyway

Good luck.

tniessen mentioned this pull request Jul 22, 2017
Closed

BridgeAR commented Aug 28, 2017

Copy link
Copy Markdown
Member

This needs a rebase

targos force-pushed the fix-path-normalize branch from 1250227 to 092094d Compare August 28, 2017 07:22

targos commented Aug 28, 2017

Copy link
Copy Markdown
Member Author

Looks like I forgot about this PR... Done.

CI: https://ci.nodejs.org/job/node-test-pull-request/9858/

jasnell commented Aug 29, 2017

Copy link
Copy Markdown
Member

CI failed on arm, trying again https://ci.nodejs.org/job/node-test-commit-arm/11784/

targos added a commit to targos/node that referenced this pull request Aug 30, 2017
path: fix normalize on directories with two dots
b98e8d9 
PR-URL: nodejs#14107
Fixes: nodejs#14105
Reviewed-By: Refael Ackermann <refack@gmail.com>

targos commented Aug 30, 2017

Copy link
Copy Markdown
Member Author

Landed in b98e8d9

targos closed this Aug 30, 2017
targos deleted the fix-path-normalize branch August 30, 2017 12:45
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
path: fix normalize on directories with two dots
36e833b 
PR-URL: nodejs/node#14107
Fixes: nodejs/node#14105
Reviewed-By: Refael Ackermann <refack@gmail.com>
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
path: fix normalize on directories with two dots
4af4eac 
PR-URL: nodejs/node#14107
Fixes: nodejs/node#14105
Reviewed-By: Refael Ackermann <refack@gmail.com>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Aug 31, 2017
path: fix normalize on directories with two dots
90f7cfa 
PR-URL: nodejs#14107
Fixes: nodejs#14105
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
path: fix normalize on directories with two dots
bee6a5e 
PR-URL: #14107
Fixes: #14105
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
path: fix normalize on directories with two dots
29f9101 
PR-URL: #14107
Fixes: #14105
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 20, 2017
path: fix normalize on directories with two dots
bc2115c 
PR-URL: #14107
Fixes: #14105
Reviewed-By: Refael Ackermann <refack@gmail.com>

MylesBorins commented Sep 20, 2017

Copy link
Copy Markdown
Contributor

I've backported to v6.x

Please let me know if it should be backed out

MylesBorins mentioned this pull request Sep 20, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 16, 2017
path: fix normalize on directories with two dots
f9d0016 
PR-URL: #14107
Fixes: #14105
Reviewed-By: Refael Ackermann <refack@gmail.com>

MylesBorins commented Oct 17, 2017

Copy link
Copy Markdown
Contributor

I've landed this back on v6.x along with 19d2d6611c which fixed the security vulnerability.

Please let me know if you think they should be backed out

/cc @nodejs/security @nodejs/tsc

MylesBorins mentioned this pull request Oct 17, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
path: fix normalize on directories with two dots
f87a626 
PR-URL: #14107
Fixes: #14105
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins mentioned this pull request Nov 3, 2017
Merged
BridgeAR mentioned this pull request Feb 14, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
refack refack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

path Issues and PRs related to the path subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL