FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: run test-hash-seed at the end of test-v8 by targos · Pull Request #14219 · nodejs/node · GitHub

/ node Public

build: run test-hash-seed at the end of test-v8 - #14219

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:makefile-test-hash-seed
ConversationCommits (1)ChecksFiles changed
Closed

build: run test-hash-seed at the end of test-v8#14219
targos wants to merge 1 commit into
nodejs:masterfrom
targos:makefile-test-hash-seed

Conversation

targos commented Jul 13, 2017

Copy link
Copy Markdown
Member

The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: #14004 (comment)

I'm open to a better solution but I don't think test-hash-seed shoud be run here, even if we make it sequential (V8 has to be built twice).

@ofrobots @nodejs/v8

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jul 13, 2017
refack previously approved these changes Jul 13, 2017
View reviewed changes

refack commented Jul 13, 2017

Copy link
Copy Markdown
Contributor

Sounds right to me. IMHO test-hash-seed is a node test (and is run under pummel) not a V8 test...

ofrobots commented Jul 13, 2017

Copy link
Copy Markdown
Contributor

The original motivation was to make sure this gets run whenever we update V8 (i.e. the time we usually run test-v8 in the CI). IMO, test-hash-seed is too slow to be run in the normal CI. Let me see if there might be another way to do this..

ofrobots commented Jul 14, 2017

Copy link
Copy Markdown
Contributor

Perhaps something like:

--- a/Makefile
+++ b/Makefile
@@ -433,13 +433,15 @@ test-async-hooks:


 ifneq ("","$(wildcard deps/v8/tools/run-tests.py)")
-test-v8: v8 test-hash-seed
+test-v8: v8
 #      note: performs full test unless QUICKCHECK is specified
        deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
         --mode=$(BUILDTYPE_LOWER) $(V8_TEST_OPTIONS) $(QUICKCHECK_ARG) \
         --no-presubmit \
         --shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \
         $(TAP_V8)
+        @echo Testing hash seed
+        $(MAKE) test-hash-seed

build: run test-hash-seed at the end of test-v8
fe8c222 
The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: nodejs#14004 (comment)
targos force-pushed the makefile-test-hash-seed branch from 0b4a01e to fe8c222 Compare July 14, 2017 06:07

targos commented Jul 14, 2017

Copy link
Copy Markdown
Member Author

CI with that change: https://ci.nodejs.org/job/node-test-commit-v8-linux/783/

targos changed the title build: do not run test-hash-seed with test-v8 build: run test-hash-seed at the end of test-v8 Jul 14, 2017
targos mentioned this pull request Jul 14, 2017
Closed
3 tasks

targos commented Jul 14, 2017

Copy link
Copy Markdown
Member Author

CI is green. Can we fast-track this fix to unbreak it?

targos commented Jul 14, 2017

Copy link
Copy Markdown
Member Author

BTW I understood why test-hash-seed was there and it makes sense. I was reluctant because of the double V8 build but the job took only 30 minutes to run so that's fine.

refack commented Jul 14, 2017

Copy link
Copy Markdown
Contributor

$(MAKE) test-hash-seed

Just to be sure, spawning a sub-make propagates the exit code?

targos commented Jul 14, 2017

Copy link
Copy Markdown
Member Author

@refack With this:

test-a: test-b
        echo "test-a"
        $(MAKE) test-c

test-b:
        echo "test-b"

test-c:
        node -e "process.exit(1)"
$ make test-a
echo "test-b"
test-b
echo "test-a"
test-a
make test-c
node -e "process.exit(1)"
make[1]: *** [Makefile:442: test-c] Error 1
make: *** [Makefile:436: test-a] Error 2

mhdawson approved these changes Jul 14, 2017
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The alternative is to make a new nightly job that just runs the hashseed test on its own. That would remove the overhead for those doing individual regression runs instead of the nightlies. We then might want to create better nightly job which runs both the hashseed and v8 test jobs.

In any case I'm +1 to landing this now to get the test back to green and the improve.

mhdawson commented Jul 14, 2017

Copy link
Copy Markdown
Member

I also think we should expedite landing this since the jobs are completely broken as they currently are.

addaleax commented Jul 14, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Landed in 016d81c

addaleax closed this Jul 14, 2017
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 14, 2017
build: run test-hash-seed at the end of test-v8
016d81c 
The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: nodejs#14004 (comment)
PR-URL: nodejs#14219
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax mentioned this pull request Jul 18, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
build: run test-hash-seed at the end of test-v8
922f58f 
The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: #14004 (comment)
PR-URL: #14219
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos deleted the makefile-test-hash-seed branch July 18, 2017 19:25
targos mentioned this pull request Jul 18, 2017
Closed
MylesBorins pushed a commit that referenced this pull request Jul 18, 2017
build: run test-hash-seed at the end of test-v8
3b2c791 
The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: #14004 (comment)
PR-URL: #14219
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins mentioned this pull request Jul 18, 2017
Merged
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
build: run test-hash-seed at the end of test-v8
8243ddc 
The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: #14004 (comment)
PR-URL: #14219
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 21, 2017
build: run test-hash-seed at the end of test-v8
8dec802 
The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: #14004 (comment)
PR-URL: #14219
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Oct 2, 2017
build: run test-hash-seed at the end of test-v8
4cb743d 
The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: nodejs#14004 (comment)
PR-URL: nodejs#14219
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Oct 18, 2017
build: run test-hash-seed at the end of test-v8
2ae2a96 
The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: #14004 (comment)
Backport-PR-URL: #15562
PR-URL: #14219
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
build: run test-hash-seed at the end of test-v8
a7f7a87 
The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: #14004 (comment)
Backport-PR-URL: #15562
PR-URL: #14219
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins mentioned this pull request Oct 25, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
+2 more reviewers
refack refack approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL