FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: replace string concatenation with template literals by leizongmin · Pull Request #14298 · nodejs/node · GitHub

/ node Public

test: replace string concatenation with template literals - #14298

Closed
leizongmin wants to merge 1 commit into
nodejs:masterfrom
leizongmin:replace_string_with_template_literals
ConversationCommits (1)ChecksFiles changed
Closed

test: replace string concatenation with template literals#14298
leizongmin wants to merge 1 commit into
nodejs:masterfrom
leizongmin:replace_string_with_template_literals

Conversation

leizongmin commented Jul 16, 2017

Copy link
Copy Markdown
Contributor
  • test/parallel/test-stdout-close-catch.js
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test: replace string concatenation with template literals

test: replace string concatenation with template literals
1b4a7cb 
* test/parallel/test-stdout-close-catch.js
nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 16, 2017
Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 16, 2017
Trott approved these changes Jul 16, 2017
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if CI is green

benjamingr approved these changes Jul 16, 2017
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm +0 on these changes in terms of cruft ratio - but actual code looks fine.

tniessen approved these changes Jul 16, 2017
View reviewed changes

tniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Same as @benjamingr.

tniessen self-assigned this Jul 16, 2017

vsemozhetbyt commented Jul 16, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/9181/

Trott commented Jul 17, 2017

Copy link
Copy Markdown
Member

CI is green! 🎉

gireeshpunathil reviewed Jul 17, 2017
View reviewed changes
Comment thread test/parallel/test-stdout-close-catch.js
const cmd = `${JSON.stringify(process.execPath)} ` +
`${JSON.stringify(testScript)} | ` +
`${JSON.stringify(process.execPath)} ` +
'-pe "process.stdin.on(\'data\' , () => process.exit(1))"';

gireeshpunathil Jul 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is there any scope for improvement here? By combining this line too?

tniessen Jul 21, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What do you suggest?

Trott pushed a commit to Trott/io.js that referenced this pull request Jul 23, 2017
test: replace concatenation with template literals
a5352d9 
* test/parallel/test-stdout-close-catch.js

PR-URL: nodejs#14298
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott commented Jul 23, 2017

Copy link
Copy Markdown
Member

Landed in a5352d9.
Thanks for the contribution! 🎉

Trott closed this Jul 23, 2017
addaleax pushed a commit that referenced this pull request Jul 24, 2017
test: replace concatenation with template literals
3414e42 
* test/parallel/test-stdout-close-catch.js

PR-URL: #14298
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax mentioned this pull request Jul 24, 2017
Closed
addaleax mentioned this pull request Aug 2, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
test: replace concatenation with template literals
742ff24 
* test/parallel/test-stdout-close-catch.js

PR-URL: #14298
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Aug 16, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
test: replace concatenation with template literals
6e08ae0 
* test/parallel/test-stdout-close-catch.js

PR-URL: #14298
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 3, 2017
test: replace concatenation with template literals
dc0be4f 
* test/parallel/test-stdout-close-catch.js

PR-URL: #14298
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
test: replace concatenation with template literals
7f7a070 
* test/parallel/test-stdout-close-catch.js

PR-URL: #14298
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 5, 2017
Closed
Closed
Closed
This was referenced Sep 6, 2017
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tniessen tniessen approved these changes
gireeshpunathil gireeshpunathil left review comments
jasnell jasnell approved these changes
Trott Trott approved these changes
benjamingr benjamingr approved these changes
+2 more reviewers
TimothyGu TimothyGu approved these changes
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

tniessen

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL