test: add DISABLED_ prefix to commented out test - #14317
Closed
danbev wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
gibfahn
approved these changes
Jul 17, 2017
Copy link
Copy Markdown
Member
|
Ahh okay, that's how you mark a test as SKIP with cctest. |
Sorry, something went wrong.
cjihrig
approved these changes
Jul 17, 2017
jasnell
approved these changes
Jul 17, 2017
Commit 95ab966 ("test: disable MultipleEnvironmentsPerIsolate") commented out MultipleEnvironmentsPerIsolate but it migth be better to disable the test so that this gets reported and not forgotten: YOU HAVE 1 DISABLED TEST
danbev
force-pushed
the
disable-test-environment
branch
from
545bb06 to
ad57ec9
Compare
July 29, 2017 05:00
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
tniessen
approved these changes
Jul 29, 2017
danbev
added a commit
to danbev/node
that referenced
this pull request
Jul 29, 2017
Commit 95ab966 ("test: disable MultipleEnvironmentsPerIsolate") commented out MultipleEnvironmentsPerIsolate but it migth be better to disable the test so that this gets reported and not forgotten: YOU HAVE 1 DISABLED TEST PR-URL: nodejs#14317 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax
pushed a commit
that referenced
this pull request
Aug 1, 2017
Commit 95ab966 ("test: disable MultipleEnvironmentsPerIsolate") commented out MultipleEnvironmentsPerIsolate but it migth be better to disable the test so that this gets reported and not forgotten: YOU HAVE 1 DISABLED TEST PR-URL: #14317 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Aug 10, 2017
This reverts commit 75bf8a9. Ref: nodejs#14206 Ref: nodejs#14317
Copy link
Copy Markdown
Contributor
|
this does not appear to be relevant to v6.x, please lmk if I'm wrong |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 95ab966 ("test: disable
MultipleEnvironmentsPerIsolate") commented out
MultipleEnvironmentsPerIsolate but it migth be better to disable
the test so that this gets reported and not forgotten:
YOU HAVE 1 DISABLED TESTChecklist
Affected core subsystem(s)
test