FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: replace string concatenation in async-hooks/test-tlswrap.js with template literals by vincentcn · Pull Request #14319 · nodejs/node · GitHub

/ node Public

test: replace string concatenation in async-hooks/test-tlswrap.js with template literals - #14319

Closed
vincentcn wants to merge 3 commits into
nodejs:masterfrom
vincentcn:testfix
ConversationCommits (3)ChecksFiles changed
Closed

test: replace string concatenation in async-hooks/test-tlswrap.js with template literals#14319
vincentcn wants to merge 3 commits into
nodejs:masterfrom
vincentcn:testfix

Conversation

vincentcn commented Jul 17, 2017 •
edited by tniessen
Loading

Copy link
Copy Markdown

[JSConf CN Code&Learn] Replace string concatenation in async-hooks/test-tlswrap.js with template literals

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

no.
Just update tests.

nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Jul 17, 2017
vincentcn changed the title Replace string concatenation in async-hooks/test-tlswrap.js with template literals test: replace string concatenation in async-hooks/test-tlswrap.js with template literals Jul 17, 2017
Trott approved these changes Jul 17, 2017
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if CI is green. If you want to take it a step further, you can replace the template literals with path.join() calls. (For example: path.join(common.fixturesDir, 'test_cert.pem'))

vincentcn commented Jul 17, 2017

Copy link
Copy Markdown
Author

Thanks @Trott .
Yes, path.join is more suitable in this case.
Updated it to use path.join instead of template literals just now.

vsemozhetbyt reviewed Jul 17, 2017
View reviewed changes
Comment thread test/async-hooks/test-tlswrap.js Outdated

vsemozhetbyt Jul 17, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should not the '/test_cert.pem' and '/test_key.pem' be the 'test_cert.pem' and 'test_key.pem'? Path delimiters shoud be inserted by path.join().

tniessen Jul 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I agree (even though this will work as far as I know).

vincentcn Jul 17, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, it is better remove the delimiters. Will update it.
Thanks.

vincentcn commented Jul 17, 2017

Copy link
Copy Markdown
Author

Updated accordingly.
Thanks.

vsemozhetbyt commented Jul 17, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/9190/

Trott reviewed Jul 17, 2017
View reviewed changes
Comment thread test/async-hooks/test-tlswrap.js Outdated
if (!common.hasCrypto)
common.skip('missing crypto');

const path = require('path');

Trott Jul 17, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is a nit pick, but can you move path below assert? In tests, we try to (but admittedly often don't) keep the built-in modules in alphabetical order. (Well, ASCII order actually. https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#lines-7-8)

Trott approved these changes Jul 17, 2017
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with or without my additional nit-pick addressed. (Nit-pick can be addressed while landing if it doesn't get addressed in this PR.)

vincentcn commented Jul 17, 2017

Copy link
Copy Markdown
Author

@Trott
Updated it to make the imports of build modules in alphabetical order.

Thanks.

AndreasMadsen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 17, 2017

vsemozhetbyt commented Jul 17, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/9196/

vsemozhetbyt reviewed Jul 17, 2017
View reviewed changes
Comment thread test/async-hooks/test-tlswrap.js Outdated

vsemozhetbyt Jul 17, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If this extra empty line is unwanted, anybody who will land the PR can delete it.

vincentcn commented Jul 18, 2017 •
edited by gibfahn
Loading

Copy link
Copy Markdown
Author

If this extra empty line is unwanted, anybody who will land the PR can delete it.

Deleted.

Trott commented Jul 21, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/9280/

tniessen commented Jul 21, 2017

Copy link
Copy Markdown
Member

Landed in d8eb30a, thank you for your first contribution! 🎉

tniessen closed this Jul 21, 2017
tniessen pushed a commit that referenced this pull request Jul 21, 2017
test: use path.join in async-hooks/test-tlswrap.js
d8eb30a 
PR-URL: #14319
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax pushed a commit that referenced this pull request Jul 22, 2017
test: use path.join in async-hooks/test-tlswrap.js
98bba54 
PR-URL: #14319
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

vincentcn commented Jul 24, 2017

Copy link
Copy Markdown
Author

Thanks.

Fishrock123 pushed a commit that referenced this pull request Jul 24, 2017
test: use path.join in async-hooks/test-tlswrap.js
3c92b78 
PR-URL: #14319
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax mentioned this pull request Jul 24, 2017
Closed
addaleax mentioned this pull request Aug 2, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tniessen tniessen approved these changes
jasnell jasnell approved these changes
Trott Trott approved these changes
benjamingr benjamingr approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
gireeshpunathil gireeshpunathil approved these changes
+1 more reviewer
vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL