FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v6.x backport] test: harden test-dgram-bind-shared-ports by refack · Pull Request #14327 · nodejs/node · GitHub

/ node Public

[v6.x backport] test: harden test-dgram-bind-shared-ports - #14327

Closed
refack wants to merge 1 commit into
nodejs:v6.x-stagingfrom
refack:backport-13100-to-v6.x
ConversationCommits (1)ChecksFiles changed
Closed

[v6.x backport] test: harden test-dgram-bind-shared-ports#14327
refack wants to merge 1 commit into
nodejs:v6.x-stagingfrom
refack:backport-13100-to-v6.x

Conversation

refack commented Jul 17, 2017

Copy link
Copy Markdown
Contributor

Ref: #13100

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test,dgram,cluster

test: harden test-dgram-bind-shared-ports
5967e4b 
* add `mustCall` and `mustNotCall` to all callbacks
* added `known_issue` for port binding

PR-URL: nodejs#13100
Refs: nodejs#13055
Refs: nodejs#12999
Refs: nodejs#13526
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs-github-bot added test Issues and PRs related to the tests. v6.x labels Jul 17, 2017
refack mentioned this pull request Jul 17, 2017
Merged
3 tasks

refack commented Jul 17, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/9197/

mscdex added dgram Issues and PRs related to the dgram subsystem / UDP. cluster Issues and PRs related to the cluster subsystem. labels Jul 17, 2017
refack mentioned this pull request Jul 17, 2017
Merged
4 tasks
refack added the blocked PRs that are blocked by other issues or PRs. label Jul 17, 2017

refack commented Jul 17, 2017

Copy link
Copy Markdown
Contributor Author

Dependant on #12935 being backported

MylesBorins commented Aug 14, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

landed in ac21bfd

MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
test: harden test-dgram-bind-shared-ports
ac21bfd 
* add `mustCall` and `mustNotCall` to all callbacks
* added `known_issue` for port binding

Backport-PR-URL: #14327
PR-URL: #13100
Refs: #13055
Refs: #12999
Refs: #13526
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
test: harden test-dgram-bind-shared-ports
189dc42 
* add `mustCall` and `mustNotCall` to all callbacks
* added `known_issue` for port binding

Backport-PR-URL: #14327
PR-URL: #13100
Refs: #13055
Refs: #12999
Refs: #13526
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
test: harden test-dgram-bind-shared-ports
a1cef1f 
* add `mustCall` and `mustNotCall` to all callbacks
* added `known_issue` for port binding

Backport-PR-URL: #14327
PR-URL: #13100
Refs: #13055
Refs: #12999
Refs: #13526
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
refack deleted the backport-13100-to-v6.x branch October 24, 2017 13:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes

Assignees

No one assigned

Labels

blocked PRs that are blocked by other issues or PRs. cluster Issues and PRs related to the cluster subsystem. dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL