FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

zlib: check if the stream is destroyed before push by mcollina · Pull Request #14330 · nodejs/node · GitHub

/ node Public

zlib: check if the stream is destroyed before push - #14330

Closed
mcollina wants to merge 1 commit into
nodejs:masterfrom
mcollina:fix-koa-compress
ConversationCommits (1)ChecksFiles changed
Closed

zlib: check if the stream is destroyed before push#14330
mcollina wants to merge 1 commit into
nodejs:masterfrom
mcollina:fix-koa-compress

Conversation

mcollina commented Jul 17, 2017

Copy link
Copy Markdown
Member

If the stream is destroyed while the transform is still being
applied, push() should not be called, and the internal state
should be cleared.

See: koajs/compress#60

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

zlib, stream

zlib: check if the stream is destroyed before push
b13e010 
If the stream is destroyed while the transform is still being
applied, push() should not be called, and the internal state
should be cleared.

See: koajs/compress#60
mcollina requested a review from mscdex July 17, 2017 17:41
nodejs-github-bot added the zlib Issues and PRs related to the zlib subsystem. label Jul 17, 2017
mcollina mentioned this pull request Jul 17, 2017
Closed
mcollina requested review from cjihrig, jasnell and targos July 17, 2017 17:44

mcollina commented Jul 17, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/9198/

cjihrig approved these changes Jul 17, 2017
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if the CI comes back OK.

mcollina mentioned this pull request Jul 18, 2017
Merged
1 task

mcollina commented Jul 18, 2017

Copy link
Copy Markdown
Member Author

CI is green.

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/910/ (cc @refack)

refack commented Jul 18, 2017

Copy link
Copy Markdown
Contributor

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/910/ (cc @refack)

Junkins is still in a funky mood, might need to re-run later... nodejs/build#798

mcollina commented Jul 19, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/915/
CITGM (master): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/916/

cc @refack can you have a look? Or is still problematic?

mcollina mentioned this pull request Jul 19, 2017
Merged

mcollina commented Jul 19, 2017

Copy link
Copy Markdown
Member Author

Landing, CITGM seems ok.

mcollina commented Jul 19, 2017

Copy link
Copy Markdown
Member Author

Landed as aa496f4.

mcollina closed this Jul 19, 2017
mcollina deleted the fix-koa-compress branch July 19, 2017 12:13
mcollina added a commit that referenced this pull request Jul 19, 2017
zlib: check if the stream is destroyed before push
aa496f4 
If the stream is destroyed while the transform is still being
applied, push() should not be called, and the internal state
should be cleared.

See: koajs/compress#60
PR-URL: #14330
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

refack commented Jul 19, 2017

Copy link
Copy Markdown
Contributor

Maybe add koa-compress to CitGM?

mcollina commented Jul 19, 2017

Copy link
Copy Markdown
Member Author

@refack koa-compress tests were passing.

refack commented Jul 19, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

@refack koa-compress tests were passing.

Will they add a regression test for this?
😕 because GitHub doesn't allow 😞

mcollina commented Jul 19, 2017

Copy link
Copy Markdown
Member Author

I couldn't reproduce this programmatically with koa-compress, but only when load-testing or when my machine was under severe load.

Fishrock123 mentioned this pull request Jul 20, 2017
Merged
3 tasks
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jul 20, 2017
zlib: check if the stream is destroyed before push
6fce1a3 
If the stream is destroyed while the transform is still being
applied, push() should not be called, and the internal state
should be cleared.

Refs: koajs/compress#60
PR-URL: nodejs#14330
Backport-PR-URL: nodejs#14396
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

 Conflicts:
	lib/zlib.js

MylesBorins commented Aug 16, 2017

Copy link
Copy Markdown
Contributor

@mcollina should this be backported? It would need to be done manually

mcollina commented Aug 16, 2017

Copy link
Copy Markdown
Member Author

This depends on #12925, which is flagged as semver-major. So, no.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
mscdex Awaiting requested review from mscdex
jasnell Awaiting requested review from jasnell
targos Awaiting requested review from targos

Assignees

No one assigned

Labels

zlib Issues and PRs related to the zlib subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL