FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[JsConf Code & Learn]test: replace string concatenation with template literals by nathansmile · Pull Request #14342 · nodejs/node · GitHub

/ node Public

[JsConf Code & Learn]test: replace string concatenation with template literals - #14342

Closed
nathansmile wants to merge 1 commit into
nodejs:masterfrom
nathansmile:nat-branch
ConversationCommits (1)ChecksFiles changed
Closed

[JsConf Code & Learn]test: replace string concatenation with template literals#14342
nathansmile wants to merge 1 commit into
nodejs:masterfrom
nathansmile:nat-branch

Conversation

nathansmile commented Jul 18, 2017

Copy link
Copy Markdown
Contributor

replace string concatenation in test/parallel/test-icu-data-dir.js with template literals

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 18, 2017
nathansmile mentioned this pull request Jul 18, 2017
Closed
4 tasks
gibfahn reviewed Jul 18, 2017
View reviewed changes
Comment thread test/parallel/test-icu-data-dir.js Outdated
const expected =
'could not initialize ICU (check NODE_ICU_DATA or ' +
'--icu-data-dir parameters)' + (common.isWindows ? '\r\n' : '\n');
`--icu-data-dir parameters)${common.isWindows ? '\r\n' : '\n'}`;

gibfahn Jul 18, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

While you're here, could you replace ${common.isWindows ? '\r\n' : '\n'} with ${os.EOL} (you'll have to const os = require('os') after line 2 as well)?

refack Jul 18, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Actually since expected is later used with str.includes(expected) you could remove the EOL completely, and fit the string in a single line.

nathansmile Jul 19, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@gibfahn sure, it will come soon~

nathansmile Jul 19, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@refack Sorry, I can't get your meanings. Do you mean the code afterconst expected ... to be one line?

gibfahn Jul 20, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@refack means this:

-    '--icu-data-dir parameters)' + (common.isWindows ? '\r\n' : '\n');
+    '--icu-data-dir parameters)'

but it was fine as it is (and arguably slightly better).

refack Jul 21, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@nathansmile sorry I missed your comment. But I landed it since it's good. 😄

refack commented Jul 18, 2017

Copy link
Copy Markdown
Contributor

@nathansmile thank you for the contribution. Hope you follow up on this and make it even better 👍

refack self-assigned this Jul 18, 2017
Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 19, 2017

joyeecheung commented Jul 19, 2017

Copy link
Copy Markdown
Member

@nathansmile I think @refack meant since expected is tested with str.includes, we do not actually expect an exact match here so the test should still pass without an EOL at the end of expected. Although I think it still does not fit into one single line after dropping the EOL..

joyeecheung commented Jul 19, 2017

Copy link
Copy Markdown
Member

BTW personally I think we should keep the EOL in expected because we would actually want to make sure there is a line break here...otherwise the output might look a bit awkward.

joyeecheung approved these changes Jul 19, 2017
View reviewed changes

joyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if CI is green

joyeecheung commented Jul 19, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/9255/

Trott requested changes Jul 19, 2017
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if CI is green

Trott approved these changes Jul 19, 2017
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if CI is green.

refack pushed a commit to refack/node that referenced this pull request Jul 19, 2017
test: replace string concatenation with template
01eddd9 
PR-URL: nodejs#14342
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

refack commented Jul 19, 2017

Copy link
Copy Markdown
Contributor

Landed in 01eddd9

refack closed this Jul 19, 2017
addaleax pushed a commit that referenced this pull request Jul 22, 2017
test: replace string concatenation with template
131a6af 
PR-URL: #14342
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Jul 24, 2017
test: replace string concatenation with template
def98c6 
PR-URL: #14342
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax mentioned this pull request Jul 24, 2017
Closed
addaleax mentioned this pull request Aug 2, 2017
Merged
refack removed their assignment Oct 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
joyeecheung joyeecheung approved these changes
+2 more reviewers
refack refack approved these changes
gibfahn gibfahn left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL