FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v6.x backport] cluster, dns, repl, tls, util: fix RegExp nits by vsemozhetbyt · Pull Request #14348 · nodejs/node · GitHub

/ node Public

[v6.x backport] cluster, dns, repl, tls, util: fix RegExp nits - #14348

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:v6.x-stagingfrom
vsemozhetbyt:backport-13536-to-v6.x
ConversationCommits (1)ChecksFiles changed
Closed

[v6.x backport] cluster, dns, repl, tls, util: fix RegExp nits#14348
vsemozhetbyt wants to merge 1 commit into
nodejs:v6.x-stagingfrom
vsemozhetbyt:backport-13536-to-v6.x

Conversation

vsemozhetbyt commented Jul 18, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

cluster, dns, repl, tls, util

Backport of #13536

  • Take RegExp creation out of cycles.
  • Use test(), not match() in boolean context.
  • Remove redundant RegExp parts.

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v6.x labels Jul 18, 2017
vsemozhetbyt mentioned this pull request Jul 18, 2017
Closed
2 tasks
cluster, dns, repl, tls, util: fix RegExp nits
22ab3b7 
* Take RegExp creation out of cycles.
* Use test(), not match() in boolean context.
* Remove redundant RegExp parts.

PR-URL: #13536
Reviewed-By: Anna Henningsen <anna@addaleax.net>

vsemozhetbyt commented Jul 18, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/9229/

MylesBorins pushed a commit that referenced this pull request Jul 18, 2017
cluster, dns, repl, tls, util: fix RegExp nits
ddc8050 
* Take RegExp creation out of cycles.
* Use test(), not match() in boolean context.
* Remove redundant RegExp parts.

Backport-PR-URL: #14348
PR-URL: #13536
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins commented Jul 18, 2017

Copy link
Copy Markdown
Contributor

landed in ddc8050

vsemozhetbyt deleted the backport-13536-to-v6.x branch July 18, 2017 23:45
MylesBorins pushed a commit that referenced this pull request Jul 21, 2017
cluster, dns, repl, tls, util: fix RegExp nits
edbe442 
* Take RegExp creation out of cycles.
* Use test(), not match() in boolean context.
* Remove redundant RegExp parts.

Backport-PR-URL: #14348
PR-URL: #13536
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes

Assignees

No one assigned

Labels

lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL