FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixes: https://github.com/nodejs/node/issues/14362 by noviluni · Pull Request #14364 · nodejs/node · GitHub

/ node Public

Fixes: https://github.com/nodejs/node/issues/14362 - #14364

Closed
noviluni wants to merge 1 commit into
nodejs:masterfrom
noviluni:master
ConversationCommits (1)ChecksFiles changed
Closed

Fixes: https://github.com/nodejs/node/issues/14362#14364
noviluni wants to merge 1 commit into
nodejs:masterfrom
noviluni:master

Conversation

noviluni commented Jul 19, 2017 •
edited by vsemozhetbyt
Loading

Copy link
Copy Markdown
Checklist
Affected core subsystem(s)

subsytem: doc

Fixes: #14362

(edited by @vsemozhetbyt: added "Fixes:")

nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jul 19, 2017
TimothyGu reviewed Jul 19, 2017
View reviewed changes

TimothyGu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you please amend the commit message to conform to our commit message guidelines?

noviluni force-pushed the master branch 2 times, most recently from 6192d69 to daa24c1 Compare July 19, 2017 12:16

noviluni commented Jul 19, 2017

Copy link
Copy Markdown
Author

Did it!

I wrote my first commit message in that way because of this line:

"If your patch fixes an open issue, you can add a reference to it at the end of the log. Use the Fixes: prefix and the full issue URL. "

Just my first time... that will not happen again :)

TimothyGu approved these changes Jul 19, 2017
View reviewed changes

TimothyGu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, and welcome to Node.js!

mscdex commented Jul 19, 2017

Copy link
Copy Markdown
Contributor

The commit message should include a Fixes: https://github.com/nodejs/node/issues/14362 line.

noviluni commented Jul 19, 2017

Copy link
Copy Markdown
Author

Thank you, just updated.

jasnell approved these changes Jul 19, 2017
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This shouldn't need to wait the normal 48 hours to land

mcollina approved these changes Jul 20, 2017
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, my bad.

TimothyGu commented Jul 21, 2017

Copy link
Copy Markdown
Member

Landed in 4d5ae30. @noviluni, welcome to Node.js!

TimothyGu closed this Jul 21, 2017
TimothyGu pushed a commit that referenced this pull request Jul 21, 2017
doc: fix typo in stream.md
4d5ae30 
PR-URL: #14364
Fixes: #14362
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
addaleax pushed a commit that referenced this pull request Jul 22, 2017
doc: fix typo in stream.md
fa1ea02 
PR-URL: #14364
Fixes: #14362
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Jul 24, 2017
doc: fix typo in stream.md
f1b09c0 
PR-URL: #14364
Fixes: #14362
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
addaleax mentioned this pull request Jul 24, 2017
Closed
addaleax mentioned this pull request Aug 2, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 19, 2017
doc: fix typo in stream.md
dcdc905 
PR-URL: #14364
Fixes: #14362
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins mentioned this pull request Sep 20, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
+2 more reviewers
TimothyGu TimothyGu approved these changes
vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL