doc: replace dead link in v8 module - #14372
Conversation
Sorry, something went wrong.
joyeecheung
left a comment
There was a problem hiding this comment.
LGTM as it is, using the 8.x version would be better but then the doc already says this data structure would change depending on v8 versions and there is more than one year until 6.x ends LTS.
Sorry, something went wrong.
cjihrig
left a comment
There was a problem hiding this comment.
LGTM, but I'd update this to the Node 8 link, and update it to the Node 6 link when it's backported.
Sorry, something went wrong.
|
Thanks! I just updated the link to node-8.0 instead. Is there anything further I need to do with this? (This is my first PR to the node.js project! 🎉) |
Sorry, something went wrong.
PR-URL: #14372 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
I believe this does not need to wait for 48 hours and we already got enough approvals. Landed in 7bc666b, thanks for your contribution and welcome to Node.js! |
Sorry, something went wrong.
PR-URL: #14372 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #14372 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #14372 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #14372 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #14372 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #14372 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Identified a dead link to the V8 GetHeapSpaceStatistics() function on the v8 module documentation page. I updated the link to the version from the 6.10 version of the V8 docs, but could easily update it to the 8.0 version if desired, for some reason.
Checklist
Affected core subsystem(s)
doc