FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

(v6.x backport) process: add --redirect-warnings command line argument by sam-github · Pull Request #14418 · nodejs/node · GitHub

/ node Public

(v6.x backport) process: add --redirect-warnings command line argument - #14418

Merged
sam-github merged 1 commit into
nodejs:v6.x-stagingfrom
sam-github:v6.x-backport-redirect-warnings
Jul 24, 2017
Merged

(v6.x backport) process: add --redirect-warnings command line argument#14418
sam-github merged 1 commit into
nodejs:v6.x-stagingfrom
sam-github:v6.x-backport-redirect-warnings

Conversation

Copy link
Copy Markdown
Contributor

The --redirect-warnings command line argument allows process warnings
to be written to a specified file rather than printed to stderr.

Also adds an equivalent NODE_REDIRECT_WARNINGS environment variable.

If the specified file cannot be opened or written to for any reason,
the argument is ignored and the warning is printed to stderr.

If the file already exists, it will be appended to.

PR-URL: #10116
Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com
Reviewed-By: Michal Zasso targos@protonmail.com
Reviewed-By: Fedor Indutny fedor.indutny@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. v6.x labels Jul 21, 2017

Copy link
Copy Markdown
Contributor Author

backport of 03e89b3 from #10116

jasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Jul 21, 2017
The --redirect-warnings command line argument allows process warnings
to be written to a specified file rather than printed to stderr.

Also adds an equivalent NODE_REDIRECT_WARNINGS environment variable.

If the specified file cannot be opened or written to for any reason,
the argument is ignored and the warning is printed to stderr.

If the file already exists, it will be appended to.

PR-URL: nodejs#10116
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
sam-github force-pushed the v6.x-backport-redirect-warnings branch from da1f2b3 to a879dc8 Compare July 24, 2017 17:30
sam-github merged commit a879dc8 into nodejs:v6.x-staging Jul 24, 2017
sam-github pushed a commit that referenced this pull request Jul 24, 2017
The --redirect-warnings command line argument allows process warnings
to be written to a specified file rather than printed to stderr.

Also adds an equivalent NODE_REDIRECT_WARNINGS environment variable.

If the specified file cannot be opened or written to for any reason,
the argument is ignored and the warning is printed to stderr.

If the file already exists, it will be appended to.

Backport-PR-URL: #14418
PR-URL: #10116
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
sam-github deleted the v6.x-backport-redirect-warnings branch July 24, 2017 17:36

Copy link
Copy Markdown
Contributor Author

@nodejs/lts I think I landed this on v6.x-staging in error, looking at https://github.com/nodejs/LTS/wiki#q4-2017-boron-6x-release-schedule, we are only planning a minor every 4 months? At least, its 4 months from the June 6 release of 6.11.0 and the Nov 7th planned release of 6.12.0. I misremembered the cadence as being a release a month, with every other month being a minor.

I guess I should back it out and restore the branch?

gibfahn commented Jul 25, 2017

Copy link
Copy Markdown
Member

@MylesBorins did this go into the rc? If so it'd probably be better for Myles to back it out (so he knows what's going on).

I'm a little surprised by the delay until the next minor, 4 months seems a little excessive. Maybe open an issue in lts and we can discuss at the next meeting.

Copy link
Copy Markdown
Contributor

Please back this out, it has not been included in the latest RC

We can do a minor next month if we want. I documented the options in the release schedule found in the wiki

sam-github restored the v6.x-backport-redirect-warnings branch July 25, 2017 15:33

Copy link
Copy Markdown
Contributor Author

Popped this off of v6.x-staging, re-PRed.

Jeyanthinath pushed a commit to Jeyanthinath/node that referenced this pull request Jul 26, 2017
The --redirect-warnings command line argument allows process warnings
to be written to a specified file rather than printed to stderr.

Also adds an equivalent NODE_REDIRECT_WARNINGS environment variable.

If the specified file cannot be opened or written to for any reason,
the argument is ignored and the warning is printed to stderr.

If the file already exists, it will be appended to.

Backport-PR-URL: nodejs#14418
PR-URL: nodejs#10116
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL