FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v8.x backport] assert: make assert.fail doc compliant by refack · Pull Request #14428 · nodejs/node · GitHub

/ node Public

[v8.x backport] assert: make assert.fail doc compliant - #14428

Closed
refack wants to merge 2 commits into
nodejs:v8.x-stagingfrom
refack:v8-port-13862
ConversationCommits (2)ChecksFiles changed
Closed

[v8.x backport] assert: make assert.fail doc compliant#14428
refack wants to merge 2 commits into
nodejs:v8.x-stagingfrom
refack:v8-port-13862

Conversation

refack commented Jul 22, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Refs: #13862

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

assert

refack added assert Issues and PRs related to the assert subsystem. v8.x labels Jul 22, 2017
nodejs-github-bot added assert Issues and PRs related to the assert subsystem. v8.x labels Jul 22, 2017
refack mentioned this pull request Jul 22, 2017
Merged
4 tasks

refack commented Jul 22, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/9299/

refack commented Jul 22, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

addaleax commented Jul 23, 2017

Copy link
Copy Markdown
Member

This does change an existing test so I’d like to run CITGM first:

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/922/

refack commented Jul 23, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This does change an existing test so I’d like to run CITGM first:

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/922/

CitGM is clean.
(also as you probably noticed, test changes are only additions. The PR started as more extensive, but what landed IMHO is semver-patch) fc46363 (#13974) leaked into this.

addaleax reviewed Jul 23, 2017
View reviewed changes
Comment thread test/parallel/test-assert-fail.js Outdated

addaleax Jul 23, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@refack This is not additive.

refack Jul 23, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

hmmmm.... right.
This is #13974 leaking into my backport. I can take it out.

addaleax Jul 23, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I would do that, the alternative is re-discussing the semverness of #13974

refack commented Jul 23, 2017

Copy link
Copy Markdown
Contributor Author

Reverted fc46363 (#13974) that leaked into this.
But also reopened discussion on semverity of #13974

refack commented Jul 23, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/9305/
(Yay for "Rebuild" nodejs/build#672)

refack commented Jul 23, 2017

Copy link
Copy Markdown
Contributor Author

refack commented Jul 24, 2017

Copy link
Copy Markdown
Contributor Author

Rebased: https://ci.nodejs.org/job/node-test-pull-request/9324/

BridgeAR added 2 commits July 24, 2017 11:56
doc,assert: document stackStartFunction in fail
94fecdf 
PR-URL: nodejs#13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
assert: refactor the code
b95ba5b 
1. Rename private functions
2. Use destructuring
3. Remove obsolete comments

PR-URL: nodejs#13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

refack commented Jul 24, 2017

Copy link
Copy Markdown
Contributor Author

Better rebase: https://ci.nodejs.org/job/node-test-commit/11341/

addaleax commented Jul 24, 2017

Copy link
Copy Markdown
Member

LGTM, thank you!

Landed in 78f0c2a, 26785a2 (with the test changes moved back to the commit that they were in originally as chatted about in IRC)

addaleax pushed a commit that referenced this pull request Jul 24, 2017
doc,assert: document stackStartFunction in fail
78f0c2a 
PR-URL: #13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Backport-PR-URL: #14428
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Jul 24, 2017
assert: refactor the code
26785a2 
1. Rename private functions
2. Use destructuring
3. Remove obsolete comments

PR-URL: #13862
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Backport-PR-URL: #14428
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax closed this Jul 24, 2017
refack deleted the v8-port-13862 branch September 18, 2017 01:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax left review comments

Assignees

No one assigned

Labels

assert Issues and PRs related to the assert subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL