FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tls: fix empty issuer/subject/infoAccess parsing by bnoordhuis · Pull Request #14473 · nodejs/node · GitHub

/ node Public

tls: fix empty issuer/subject/infoAccess parsing - #14473

Closed
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:fix11771-base
ConversationCommits (1)ChecksFiles changed
Closed

tls: fix empty issuer/subject/infoAccess parsing#14473
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:fix11771-base

Conversation

bnoordhuis commented Jul 25, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Also issuerCertificate but that did not fit on the status line.

Fixes: #11771

Split off from #14447.

CI: https://ci.nodejs.org/job/node-test-pull-request/9342/

tls: fix empty issuer/subject/infoAccess parsing
7d6cb85 
Also issuerCertificate but that did not fit on the status line.

Fixes: nodejs#11771
nodejs-github-bot added the tls Issues and PRs related to the tls subsystem. label Jul 25, 2017
This was referenced Jul 25, 2017
Closed
Closed
mcollina approved these changes Jul 25, 2017
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Comment thread lib/_tls_common.js
if (c.subject) c.subject = tls.parseCertString(c.subject);
if (c.infoAccess) {
if (c.subject != null) c.subject = tls.parseCertString(c.subject);
if (c.infoAccess != null) {

mcollina Jul 25, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

can you put a quick comment that != null  matches both null and undefined? I think that might not be newbie-friendly (also because in every guide about JS it is written to use ===).

bnoordhuis Jul 25, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'll add a comment if you insist but we use the x != null idiom all over the code base. It's not unique to this PR and we don't call it out explicitly anywhere else.

bnoordhuis closed this Jul 27, 2017
bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Jul 27, 2017
tls: fix empty issuer/subject/infoAccess parsing
06a684a 
Also issuerCertificate but that did not fit on the status line.

Fixes: nodejs#11771
PR-URL: nodejs#14473
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax pushed a commit that referenced this pull request Jul 27, 2017
tls: fix empty issuer/subject/infoAccess parsing
e90af29 
Also issuerCertificate but that did not fit on the status line.

Fixes: #11771
PR-URL: #14473
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

refack commented Jul 30, 2017

Copy link
Copy Markdown
Contributor

Landed in 06a684a

addaleax mentioned this pull request Aug 2, 2017
Merged

MylesBorins commented Aug 16, 2017

Copy link
Copy Markdown
Contributor

should this be backported to v6.x?

bnoordhuis commented Aug 16, 2017

Copy link
Copy Markdown
Member Author

Yes.

MylesBorins pushed a commit that referenced this pull request Sep 19, 2017
tls: fix empty issuer/subject/infoAccess parsing
3a6392b 
Also issuerCertificate but that did not fit on the status line.

Fixes: #11771
PR-URL: #14473
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins mentioned this pull request Sep 20, 2017
Merged
ryzokuken mentioned this pull request Sep 23, 2018
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
refack refack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL