FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

crypto: change segmentation faults to CHECKs by tniessen · Pull Request #14548 · nodejs/node · GitHub

/ node Public

crypto: change segmentation faults to CHECKs - #14548

Closed
tniessen wants to merge 3 commits into
nodejs:masterfrom
tniessen:fix-domain-array-segfault
ConversationCommits (3)ChecksFiles changed
Closed

crypto: change segmentation faults to CHECKs#14548
tniessen wants to merge 3 commits into
nodejs:masterfrom
tniessen:fix-domain-array-segfault

Conversation

tniessen commented Jul 30, 2017

Copy link
Copy Markdown
Member

Fixes: #14519

I intentionally did not fix this in cares_wrap.cc as @addaleax already did that in #14518 (assuming it gets merged).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

tniessen added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Jul 30, 2017
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Jul 30, 2017

tniessen commented Jul 30, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/9411/

tniessen self-assigned this Jul 30, 2017
addaleax reviewed Jul 30, 2017
View reviewed changes
Comment thread src/node_crypto.cc Outdated
env->domain_string(),
env->domain_array()->Get(0)).FromJust();
env->domain_array()->Get(env->context(), 0).ToLocalChecked())
.FromJust();

addaleax Jul 30, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

actually, indentation nit: 4 spaces ;)

tniessen Jul 30, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, done :)

TimothyGu reviewed Jul 31, 2017
View reviewed changes
Comment thread src/node_crypto.cc Outdated
obj->Set(env->domain_string(), env->domain_array()->Get(0));
if (env->in_domain()) {
obj->Set(env->domain_string(),
env->domain_array()->Get(env->context(), 0).ToLocalChecked());

TimothyGu Jul 31, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Any reason not to call .FromJust() here and below as well (à la RandomBytesBuffer())?

tniessen Jul 31, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I added checks to the result of Set() :)

tniessen commented Jul 31, 2017

Copy link
Copy Markdown
Member Author

New CI: https://ci.nodejs.org/job/node-test-pull-request/9418/

jasnell commented Jul 31, 2017

Copy link
Copy Markdown
Member

This could likely benefit from a test.

tniessen added a commit that referenced this pull request Aug 2, 2017
crypto: change segmentation faults to CHECKs
1c36243 
PR-URL: #14548
Fixes: #14519
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

tniessen commented Aug 2, 2017

Copy link
Copy Markdown
Member Author

Landed in 1c36243.

This could likely benefit from a test.

@jasnell I considered adding one, but I was unable to cause a segmentation fault from JavaScript without using an undocumented internal API (process._setupDomainUse) in a very hackish way, and I didn't think it was a good idea to write a test revolving around that.

CI on master: https://ci.nodejs.org/job/node-test-commit-linuxone/7699/

tniessen closed this Aug 2, 2017
addaleax pushed a commit that referenced this pull request Aug 2, 2017
crypto: change segmentation faults to CHECKs
51c1afa 
PR-URL: #14548
Fixes: #14519
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax mentioned this pull request Aug 2, 2017
Merged

MylesBorins commented Aug 16, 2017

Copy link
Copy Markdown
Contributor

This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
TimothyGu TimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

tniessen

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Internal domain function can be used to cause segfaults

7 participants

Back | FazBrowse Home | New Git URL