FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

dgram: add custom lookup function in sockets by cjihrig · Pull Request #14560 · nodejs/node · GitHub

/ node Public

dgram: add custom lookup function in sockets - #14560

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:lookup
Aug 3, 2017
ConversationCommits (1)ChecksFiles changed
Merged

dgram: add custom lookup function in sockets#14560
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:lookup

Conversation

cjihrig commented Aug 1, 2017

Copy link
Copy Markdown
Contributor

This commit adds support for custom DNS lookup functions in dgram sockets. This is similar to the existing feature in net sockets.

Refs: #6189

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

dgram

nodejs-github-bot added the dgram Issues and PRs related to the dgram subsystem / UDP. label Aug 1, 2017

Trott commented Aug 1, 2017

Copy link
Copy Markdown
Member

semver-minor?

cjihrig added the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 1, 2017

cjihrig commented Aug 1, 2017

Copy link
Copy Markdown
Contributor Author

Yes, added the label. Thanks.

geek reviewed Aug 1, 2017
View reviewed changes
Comment thread doc/api/dgram.md Outdated

geek Aug 1, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Would be nice to provide the function signature

cjihrig Aug 1, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I copied that directly from the net docs for the same feature.

cjihrig commented Aug 2, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/9453/

dgram: add custom lookup function in sockets
5a05055 
This commit adds support for custom DNS lookup functions in
dgram sockets. This is similar to the existing feature in net
sockets.

Refs: nodejs#6189
PR-URL: nodejs#14560
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
cjihrig merged commit 5a05055 into nodejs:master Aug 3, 2017
cjihrig deleted the lookup branch August 3, 2017 00:34

addaleax commented Aug 10, 2017

Copy link
Copy Markdown
Member

This doesn’t land cleanly on 8.x; if you can, please follow the guide and raise a backport PR, if you don’t think it’s worth it just add the dont-land-on label.

jasnell mentioned this pull request Sep 20, 2017
Closed
4 tasks

jasnell commented Sep 20, 2017

Copy link
Copy Markdown
Member

Ping @cjihrig ... Initial basic attempts to backport this for v8.x are failing due to some issue with dns. Will investigate further shortly.

cjihrig commented Sep 22, 2017

Copy link
Copy Markdown
Contributor Author

@jasnell not sure. The commit in this PR lands cleanly for me on v8.x-staging. I ran the test suite locally and only saw one unrelated failure (test/sequential/test-benchmark-http.js).

jasnell commented Sep 22, 2017

Copy link
Copy Markdown
Member

It's likely that the commits I landed today unblocked it. I'll try again tomorrow

jasnell pushed a commit that referenced this pull request Sep 25, 2017
dgram: add custom lookup function in sockets
2944ea6 
This commit adds support for custom DNS lookup functions in
dgram sockets. This is similar to the existing feature in net
sockets.

Refs: #6189
PR-URL: #14560
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
jasnell added a commit that referenced this pull request Sep 26, 2017
2017-09-26, Node.js Version 8.6.0 (Current)
b48ff2a 
* **crypto**
  * Support for multiple ECDH curves. [#15206](#15206)
* **dgram**
  * Added `setMulticastInterface()` API. [#7855](#7855)
  * Custom lookup functions are now supported. [#14560](#14560)
* **n-api**
  * The command-line flag is no longer required to use N-API. [#14902](#14902)
* **tls**
  * Docs-only deprecation of `parseCertString()`. [#14245](#14245)
* **New Contributors**
  * Welcome Sebastiaan Deckers (@sebdeckers) as a new Collaborator! [#15354](#15354)
jasnell added a commit that referenced this pull request Sep 26, 2017
2017-09-26, Node.js Version 8.6.0 (Current)
05e4c1d 
* **crypto**
  * Support for multiple ECDH curves. [#15206](#15206)
* **dgram**
  * Added `setMulticastInterface()` API. [#7855](#7855)
  * Custom lookup functions are now supported. [#14560](#14560)
* **n-api**
  * The command-line flag is no longer required to use N-API. [#14902](#14902)
* **tls**
  * Docs-only deprecation of `parseCertString()`. [#14245](#14245)
* **New Contributors**
  * Welcome Sebastiaan Deckers (@sebdeckers) as a new Collaborator! [#15354](#15354)
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
2017-09-26, Node.js Version 8.6.0 (Current)
8f07f00 
* **crypto**
  * Support for multiple ECDH curves. [#15206](#15206)
* **dgram**
  * Added `setMulticastInterface()` API. [#7855](#7855)
  * Custom lookup functions are now supported. [#14560](#14560)
* **n-api**
  * The command-line flag is no longer required to use N-API. [#14902](#14902)
* **tls**
  * Docs-only deprecation of `parseCertString()`. [#14245](#14245)
* **New Contributors**
  * Welcome Sebastiaan Deckers (@sebdeckers) as a new Collaborator! [#15354](#15354)
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 30, 2017
2017-09-26, Node.js Version 8.6.0 (Current)
b7374d9 
* **crypto**
  * Support for multiple ECDH curves. [#15206](nodejs/node#15206)
* **dgram**
  * Added `setMulticastInterface()` API. [#7855](nodejs/node#7855)
  * Custom lookup functions are now supported. [#14560](nodejs/node#14560)
* **n-api**
  * The command-line flag is no longer required to use N-API. [#14902](nodejs/node#14902)
* **tls**
  * Docs-only deprecation of `parseCertString()`. [#14245](nodejs/node#14245)
* **New Contributors**
  * Welcome Sebastiaan Deckers (@sebdeckers) as a new Collaborator! [#15354](nodejs/node#15354)

gibfahn commented Jan 15, 2018

Copy link
Copy Markdown
Member

Release team were -1 on landing on v6.x, if you disagree let us know.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+2 more reviewers
geek geek approved these changes
evanlucas evanlucas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dgram Issues and PRs related to the dgram subsystem / UDP. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL