test: improve multiple timers tests - #14616
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jasnell
force-pushed
the
improve-timers-tests
branch
from
2840276 to
94cd7f2
Compare
August 4, 2017 01:10
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
No worries! :-) enjoy your weekend! |
Sorry, something went wrong.
addaleax
approved these changes
Aug 7, 2017
refack
approved these changes
Aug 7, 2017
refack
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
non blocking nits
Sorry, something went wrong.
Comment thread
test/parallel/test-timers-unrefd-interval-still-fires.js
| console.error('[FAIL] Interval fired %d/%d times.', nbIntervalFired, N); | ||
| throw new Error('Test timed out. keepOpen was not canceled.'); | ||
| }, TEST_DURATION); | ||
| const keepOpen = |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
nit: This is an uncommon wrapping, IMHO
const keepOpen = setTimeout(
common.mustNotCall('Test timed out. keepOpen was not canceled.'),
TEST_DURATION
);is more "regular".
Alltought
const keepOpenMsg = 'Test timed out. keepOpen was not canceled.'
const keepOpen = setTimeout(common.mustNotCall(keepOpenMsg), TEST_DURATION);is usually my preference.
Sorry, something went wrong.
Comment thread
test/parallel/test-timers-zero-timeout.js
|
|
||
| { | ||
| let ncalled = 0; | ||
| let ncalled = 3; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
nit: camelCase nCalled
Sorry, something went wrong.
jasnell
added a commit
that referenced
this pull request
Aug 8, 2017
PR-URL: #14616 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Aug 10, 2017
PR-URL: #14616 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 19, 2017
PR-URL: #14616 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General improvements to various timers tests
Checklist
Affected core subsystem(s)
tests