benchmark: remove unused parameters - #14640
Closed
nishijayaraj wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Functions onOnline and onMessage in benchmark/cluster/echo.js had unused parameters. They were removed.
Copy link
Copy Markdown
Contributor
|
So even in TF&I having the callback's signature match the call is a little bit more performant, so for function onOnline(msg) onMessage IMHO the formal argument should stay, but renamed (my preference is _ , but I yield to the OP's). |
Sorry, something went wrong.
lpinca
approved these changes
Aug 5, 2017
lpinca
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The little performance diff does not affect benchmark results.
Sorry, something went wrong.
jasnell
approved these changes
Aug 5, 2017
tniessen
approved these changes
Aug 5, 2017
Trott
approved these changes
Aug 5, 2017
BridgeAR
approved these changes
Aug 8, 2017
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Aug 8, 2017
Functions onOnline and onMessage in benchmark/cluster/echo.js had unused parameters. They were removed. PR-URL: #14640 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Aug 10, 2017
Functions onOnline and onMessage in benchmark/cluster/echo.js had unused parameters. They were removed. PR-URL: #14640 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functions onOnline and onMessage in benchmark/cluster/echo.js
had unused parameters. They were removed.
Checklist
Affected core subsystem(s)