FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix test-readline-interface short delay by Azard · Pull Request #14677 · nodejs/node · GitHub

/ node Public

test: fix test-readline-interface short delay - #14677

Closed
Azard wants to merge 2 commits into
nodejs:masterfrom
Azard:test-readline-interface-delay
ConversationCommits (2)ChecksFiles changed
Closed

test: fix test-readline-interface short delay#14677
Azard wants to merge 2 commits into
nodejs:masterfrom
Azard:test-readline-interface-delay

Conversation

Azard commented Aug 7, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Previous unit test delay is too short for parallel test on raspberry pi, it will fail sometimes.
This PR use common.platformTimeout and widen the time gap, a patch of #13497

Refs: #14674

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

readline

  • test-readline-interface

nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 7, 2017
mscdex added the readline Issues and PRs related to the built-in readline module. label Aug 7, 2017
Trott mentioned this pull request Aug 8, 2017
Closed
2 tasks

Trott commented Aug 8, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/9536/

Trott reviewed Aug 8, 2017
View reviewed changes
Comment thread test/parallel/test-readline-interface.js Outdated
const fi = new FakeInput();
const delay = 200;
const crlfDelay = 500;
const delay = common.platformTimeout(125);

Trott Aug 8, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Would this be more reliable without common.platformTimeout() here but keeping it in the line below?

Azard Aug 8, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@Trott Make sense, I have changed this line.

Trott commented Aug 8, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/9541/

Trott commented Aug 8, 2017

Copy link
Copy Markdown
Member

Stress test on master (should show failures): https://ci.nodejs.org/job/node-stress-single-test-pi1-fanned/27/

Stress test on this PR (should be green): https://ci.nodejs.org/job/node-stress-single-test-pi1-fanned/28/

Trott commented Aug 8, 2017

Copy link
Copy Markdown
Member

CI is good, stress tests are great, change is small, will help flip one of our CI tasks from red to green, 4 approvals, so I'm going to fast-track this...

Trott commented Aug 8, 2017

Copy link
Copy Markdown
Member

Landed in f11379d

Trott closed this Aug 8, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Aug 8, 2017
test: fix test-readline-interface
f11379d 
Previous unit test delay is too short for parallel test on raspberry pi,
it will fail sometimes.  This PR use common.platformTimeout and widen
the time gap.

PR-URL: nodejs#14677
Ref: nodejs#14674
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax pushed a commit that referenced this pull request Aug 10, 2017
test: fix test-readline-interface
935d34b 
Previous unit test delay is too short for parallel test on raspberry pi,
it will fail sometimes.  This PR use common.platformTimeout and widen
the time gap.

PR-URL: #14677
Ref: #14674
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax mentioned this pull request Aug 13, 2017
Merged
Azard mentioned this pull request Aug 17, 2017
Closed
4 tasks
MylesBorins pushed a commit that referenced this pull request Sep 19, 2017
test: fix test-readline-interface
8dfc283 
Previous unit test delay is too short for parallel test on raspberry pi,
it will fail sometimes.  This PR use common.platformTimeout and widen
the time gap.

PR-URL: #14677
Ref: #14674
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins mentioned this pull request Sep 20, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
refack refack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

readline Issues and PRs related to the built-in readline module. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL