src,http2: DRY header/trailer handling code up - #14688
Closed
addaleax wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Remove duplicate code through minor refactoring.
bnoordhuis
approved these changes
Aug 8, 2017
bnoordhuis
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with a suggestion.
Sorry, something went wrong.
Comment thread
src/node_http2_core.h
Outdated
|
|
||
| class SubmitTrailers { | ||
| public: | ||
| void operator ()(nghttp2_nv* trailers, size_t length) const; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Making this a normal method called .Send() or whatever is clearer, IMO. No risk of confusing method calls with plain function calls.
Sorry, something went wrong.
jasnell
approved these changes
Aug 8, 2017
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Woo! 🎈
Sorry, something went wrong.
cjihrig
approved these changes
Aug 8, 2017
danbev
approved these changes
Aug 8, 2017
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
3 tasks
addaleax
added a commit
that referenced
this pull request
Aug 10, 2017
Remove duplicate code through minor refactoring. PR-URL: #14688 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Aug 13, 2017
Remove duplicate code through minor refactoring. PR-URL: nodejs#14688 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
addaleax
added a commit
that referenced
this pull request
Aug 14, 2017
Remove duplicate code through minor refactoring. PR-URL: #14688 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicate code through minor refactoring.
Checklist
Affected core subsystem(s)
src/http2