docs: fix cli.md and delint - #14707
Merged
refack merged 2 commits intoAug 14, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
/cc @nodejs/documentation |
Sorry, something went wrong.
thefourtheye
reviewed
Aug 9, 2017
Comment thread
doc/api/n-api.md
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Is this necessary?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
The comment? I felt like it wasn't obvious why the added disable no-unused-definitions, I can rephrase, also happy to take suggestions.
Sorry, something went wrong.
lpinca
approved these changes
Aug 9, 2017
tniessen
reviewed
Aug 9, 2017
Comment thread
doc/api/intl.md
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Ref #14711
Sorry, something went wrong.
watilde
approved these changes
Aug 9, 2017
thefourtheye
approved these changes
Aug 9, 2017
PR-URL: nodejs#14707 Refs: nodejs#12756 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: nodejs#14707 Refs: nodejs#12756 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
2 tasks
Merged
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
PR-URL: nodejs#14707 Refs: nodejs#12756 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
used remark-lint from #12756
Refs: #12756
Checklist
Affected core subsystem(s)
doc